Repository navigation
Add test case for changed lined numbers in use-walrus-if - #336
Merged
Merged
Conversation
Contributor
Author
|
Bumped the unit test timeout since we keep hitting on this for the Python 3.12 tests. See #338. |
drdavella
enabled auto-merge
March 6, 2024 21:27
andrecsilva
reviewed
Mar 7, 2024
andrecsilva
left a comment
andrecsilva
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure what is the problem here. The current behavior seems to be correct as it reports the node positions of the ifs in the original code.
| self.run_and_assert(tmpdir, input_code, expected_output) | ||
|
|
||
| @pytest.mark.xfail(reason="Need to recompute line numbers to reflect removed lines") | ||
| def test_multiple_warlus_changes(self, tmpdir): |
Contributor
Author
|
@andrecsilva the line locations here affect the position of the comments in CodeTF. In general we frame our comments in terms of the fix rather than the problem and we want the comments to appear on the right side of the split diff, which means they need to be associated with new code positions. |
drdavella
force-pushed
the
add-walrus-test-case
branch
from
March 8, 2024 14:48
7f2ae59 to
d6ac755
Compare
|
clavedeluna
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add (failing) test case for computed line numbers in
use-walrus-ifDetails