Conversation
- `$a = &$this->prop['key']` modifies the property itself, so readonly, @readonly and asymmetric-visibility properties now report it the same way as `$a = &$this->prop`, including nested and appended dims. - Elements of a property that holds an ArrayAccess object are not reported: they are reached through offsetGet() and do not touch the property. A type that may be ArrayAccess is reported. - The three rules share one lookup in PropertyReflectionFinder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#14243
$a = &$this->prop['key']modifies the property itself, but only$a = &$this->propwas reported. The rules now look through array dims (nested and[]too) to the property fetch, for native readonly,@readonlyand asymmetric visibility. Without the last one,&$obj->ro['x']from outside the class would be reported on PHP 8.2 but not on 8.4+, wherePropertyAssignRefRulereports readonly writes from outside.Elements of a property holding an
ArrayAccessobject are skipped, since they go throughoffsetGet()and PHP does not throw; a type that is only maybeArrayAccess(e.g.array|ArrayAccess) is still reported, the same wayPropertyAssignNode::isArrayAccessOffsetWrite()treats it. I checked the runtime behaviour of each case on PHP 8.2 and 8.5. Messages and identifiers are unchanged.