Repository navigation
Memoize hasInstanceProperty() into its own cache - #6597
Merged
Merged
Conversation
The last two answers of ClassReflection::hasInstanceProperty() were written into $this->hasPropertyCache. A class with a static property then answered hasProperty() with false once hasInstanceProperty() had been asked first, and the negative instance answer was never memoized at all. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GupuyaR5X7EJcxUsWaFzjg
ondrejmirtes
force-pushed
the
fix-has-instance-property-cache
branch
from
September 25, 2026 20:18
3131180 to
74c3942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassReflection::hasInstanceProperty()wrote its last two answers (the require-extends one and the finalfalse) into$this->hasPropertyCacheinstead of$this->hasInstancePropertyCache.Consequences:
$xansweredhasProperty('x')withfalseoncehasInstanceProperty('x')had been asked first.@phpstan-require-extends: an interface requiring such a class got an order-dependenthasProperty()answer.hasInstanceProperty()answer was never memoized.The turbo twin in
turbo-ext/src/ClassReflection.cppmirrored the bug and gets the same fix. The second commit bumps the expected turbo version.The regression test in
ClassReflectionTestfails before the fix both without and with the extension loaded.🤖 Generated with Claude Code
https://claude.ai/code/session_01GupuyaR5X7EJcxUsWaFzjg