Test return-type extensions against a configured PHP version range

The nsrt file only covers narrowing through PHP_VERSION_ID, which makes the analysed version certain. Pin the uncertain case too: with phpVersion min 70400 / max 80500 every version check inside the converted extensions is Maybe, and the inferred type has to stay wide enough for both ends. Covers the four expressions that widen at a range - substr(), str_split(''), mb_substitute_character() with null and with 0 - and the version_compare() regression, which fails here without the previous fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
phpstan-bot · Sep 22, 2026 · Sep 22, 2026 · Sep 22, 2026 · Sep 22, 2026 · Sep 22, 2026
commit b2db47673fd3385551d73cdcf31ca3610e67e253
diff --git a/tests/PHPStan/Analyser/ScopePhpVersionRangeReturnTypeExtensionsTest.php b/tests/PHPStan/Analyser/ScopePhpVersionRangeReturnTypeExtensionsTest.php
@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser;
+
+use PHPStan\Testing\TypeInferenceTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
+
+class ScopePhpVersionRangeReturnTypeExtensionsTest extends TypeInferenceTestCase
+{
+
+	public static function dataFileAsserts(): iterable
+	{
+		yield from self::gatherAssertTypes(__DIR__ . '/data/scope-php-version-range-return-type-extensions.php');
+	}
+
+	/**
+	 * @param mixed ...$args
+	 */
+	#[DataProvider('dataFileAsserts')]
+	public function testFileAsserts(
+		string $assertType,
+		string $file,
+		...$args,
+	): void
+	{
+		$this->assertFileAsserts($assertType, $file, ...$args);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/scopePhpVersionRange.neon',
+		];
+	}
+
+}
diff --git a/tests/PHPStan/Analyser/data/scope-php-version-range-return-type-extensions.php b/tests/PHPStan/Analyser/data/scope-php-version-range-return-type-extensions.php
@@ -0,0 +1,28 @@
+<?php
+
+namespace ScopePhpVersionRangeReturnTypeExtensions;
+
+use function PHPStan\Testing\assertType;
+
+// The analysed PHP version is configured as the range 7.4 - 8.5, so every version check
+// inside these extensions is uncertain. An uncertain check must not produce a type that is
+// narrower than the truth on either end of the range.
+
+function bothVersionsPossible(string $s): void
+{
+	assertType("''|false", substr('abc', 10));
+	assertType("array{}|array{''}", str_split(''));
+	assertType('bool', mb_substitute_character(null));
+	assertType('bool', mb_substitute_character(0));
+}
+
+function validOperatorNeverReturnsNull(string $a, string $b): void
+{
+	// version_compare() only returns null for an invalid operator, so a constant valid one
+	// rules null out no matter which version of the range is analysed.
+	assertType('bool', version_compare($a, $b, '<'));
+	assertType('bool', version_compare($a, $b, 'ge'));
+
+	assertType('(bool|null)', version_compare($a, $b, 'nope'));
+	assertType('(bool|null)', version_compare($a, $b, $s));
+}
diff --git a/tests/PHPStan/Analyser/scopePhpVersionRange.neon b/tests/PHPStan/Analyser/scopePhpVersionRange.neon
@@ -0,0 +1,4 @@
+parameters:
+	phpVersion:
+		min: 70400
+		max: 80500