Skip to content

Erase generic type arguments when comparing a class-string against a constant class-string #6485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phpstan-bot wants to merge 6 commits into from
Closed

Erase generic type arguments when comparing a class-string against a constant class-string #6485

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4728624
Erase generic type arguments when comparing a `class-string` against …
phpstan-bot Sep 20, 2026
36e6600
Inline the single-use type argument erasure into isValueOfGenericType
phpstan-bot Sep 20, 2026
2b78e04
Lint the match() reproducer only on PHP 8.0+
phpstan-bot Sep 22, 2026
4102d83
Added regression test for static::class comparison in a generic class
phpstan-bot Sep 22, 2026
740aaeb
Mirror the class-string type argument erasure in the native Type classes
phpstan-bot Sep 22, 2026
18003c7
Bump expected turbo version
phpstan-bot Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Inline the single-use type argument erasure into isValueOfGenericType 
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
  • Loading branch information
@phpstan-bot @claude @VincentLanglet
2 people authored and VincentLanglet committed Sep 22, 2026
commit 36e6600d79b36de86654504624a6a3f3c329e572
22 changes: 8 additions & 14 deletions src/Type/Generic/GenericClassStringType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,26 +129,20 @@ public static function isValueOfGenericType(Type $genericType, string $className
$genericType = $genericType->getBound();
}

// We are transforming constant class-string to ObjectType. But we need to filter out
// an uncertainty originating in possible ObjectType's class subtypes.
return self::eraseTypeArguments($genericType)->isSuperTypeOf(new ObjectType($className));
}

/**
* A class-string carries a class name and never its type arguments, so the type
* arguments must not take part in the comparison against a constant class-string:
* `X::class` is a value of `class-string<X<int>>` and of `class-string<X<*>>` just
* like it is of `class-string<X>`.
*/
private static function eraseTypeArguments(Type $type): Type
{
return TypeTraverser::map($type, static function (Type $type, callable $traverse): Type {
// A class-string carries a class name and never its type arguments, so the type
// arguments must not take part in the comparison: `X::class` is a value of
// `class-string<X<int>>` and of `class-string<X<*>>` just like it is of `class-string<X>`.
$genericType = TypeTraverser::map($genericType, static function (Type $type, callable $traverse): Type {
if ($type instanceof GenericObjectType) {
return new ObjectType($type->getClassName(), $type->getSubtractedType());
}

return $traverse($type);
});

// We are transforming constant class-string to ObjectType. But we need to filter out
// an uncertainty originating in possible ObjectType's class subtypes.
return $genericType->isSuperTypeOf(new ObjectType($className));
}

public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
Expand Down