Repository navigation
Add the PHP 8.5 trace key to error_get_last() - #6470
Merged
Merged
Conversation
PHP 8.5 adds the `fatal_error_backtraces` INI setting, which is enabled by default. PHP then collects a backtrace for fatal errors and `error_get_last()` returns it under the `trace` key. The key is only present for fatal errors, and only in code that runs after shutdown, so it is optional. The frame shape matches the one `debug_backtrace()` already uses. Co-Authored-By: Claude Code
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.5 added the
fatal_error_backtracesINI setting, which is enabled by default. PHP then collects a backtrace for fatal errors, anderror_get_last()returns it under thetracekey:The RFC only populates the key for fatal errors, and only in code that runs after shutdown, so the key is optional. The frame shape is the one
debug_backtrace()already uses infunctionMap.php.Real-world impact: reading the new key currently reports
Offset 'trace' ... does not exist, and because the value then narrows tonull, every guard below it turns intoStrict comparison ... will always evaluate to trueandUnreachable statement. That makes the error unsuppressable in practice — an ignore silences the offset error but leaves the dead-code errors behind.Follows the
session_get_cookie_params()change in #6004, which added the PHP 8.5partitionedkey the same way.