Skip to content

Describe Random\Randomizer array, bytes and integer methods with dedicated dynamic return type extensions #6469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 14 commits into from
Sep 19, 2026
+513 −47
Merged

Describe Random\Randomizer array, bytes and integer methods with dedicated dynamic return type extensions #6469

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e62aa81
Describe `Random\Randomizer` array, bytes and integer methods with de…
phpstan-bot Sep 17, 2026
e6c8585
Leave `Randomizer::getBytesFromString()` to the function map
phpstan-bot Sep 17, 2026
2191d73
Describe Randomizer methods through the extensions of the functions t…
phpstan-bot Sep 17, 2026
091c272
Ask the scope for the type of the function calls Randomizer methods m…
phpstan-bot Sep 17, 2026
c5e2b1c
Leave strrev() alone, keep the accessory logic inside each extension
phpstan-bot Sep 17, 2026
b7a7245
Describe pickArrayKeys() as an array cast of the array_rand() it mirrors
phpstan-bot Sep 18, 2026
4a92ccf
Fix Ci
VincentLanglet Sep 18, 2026
3fcec81
Guard the Randomizer test file behind lint >= 8.2
phpstan-bot Sep 18, 2026
46a7a21
Drop the now-empty str_shuffle() stub
phpstan-bot Sep 18, 2026
bd8eb9f
Assert str_shuffle() over an intersection of accessory string types
phpstan-bot Sep 18, 2026
a4f9d63
Cover pickArrayKeys() over arrays with numeric string keys
phpstan-bot Sep 18, 2026
fc35282
Cover Randomizer::getFloat() and nextFloat()
phpstan-bot Sep 18, 2026
85a6a1d
Cover Randomizer methods against same-named functions and class in th…
phpstan-bot Sep 18, 2026
27f4408
Cover pickArrayKeys() over decimal-int-string and non-decimal-int-str…
phpstan-bot Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cover Randomizer::getFloat() and nextFloat() 
Both were added in PHP 8.3 alongside getBytesFromString(), but unlike it
they have nothing more precise to say than the float they declare - PHPStan
has no float range types - so they get no signature map entry, only
assertions pinning that down.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
  • Loading branch information
@phpstan-bot @claude @staabm
2 people authored and staabm committed Sep 18, 2026
commit fc35282da67f60855e0aa8c96c0ac56107ec7891
10 changes: 10 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-15256-83.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Bug15256Php83;

use Random\IntervalBoundary;
use Random\Randomizer;
use function PHPStan\Testing\assertType;

Expand All @@ -21,3 +22,12 @@ function getBytesFromString(
assertType('non-empty-string', $randomizer->getBytesFromString($lowercaseString, 5));
assertType('non-empty-string', $randomizer->getBytesFromString('abc', 5));
}

// PHPStan has no float range types, so there is nothing more precise to say
// about these than the float the class declares.
function floatMethods(Randomizer $randomizer, float $float): void
{
assertType('float', $randomizer->nextFloat());
assertType('float', $randomizer->getFloat(0.0, 1.0));
assertType('float', $randomizer->getFloat($float, $float, IntervalBoundary::ClosedClosed));
}