Repository navigation
Remove the PHP version constraint from the #[\NoDiscard] attribute rules. - #6444
Merged
Merged
Conversation
claudepache
force-pushed
the
nodiscard
branch
from
September 14, 2026 15:32
b0626b2 to
6ec302a
Compare
ondrejmirtes
requested changes
Sep 14, 2026
ondrejmirtes
left a comment
ondrejmirtes
left a comment
Member
There was a problem hiding this comment.
Other than the note I'm okay with this 👍
claudepache
force-pushed
the
nodiscard
branch
from
September 14, 2026 16:36
6ec302a to
4e86a15
Compare
ondrejmirtes
approved these changes
Sep 14, 2026
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same reasoning as #4436.
In short: Currently, the rules triggered by the
#[NoDiscard]attribute are enabled for PHP 8.5+ only, because the attribute was introduced in 8.5. However, as the rules are already implicitly opt-in by the presence of the attribute, there is no need to add a version constraint.This PR proposes to remove the PHP version constraint from these rules, so that they can be applied to a codebase which supports versions of PHP older than 8.5 and still benefit from static analysis by PHPStan.
Note that the companion VoidCastRule is not touched: the
(void)cast remains only available in PHP 8.5+.Fixes phpstan/phpstan#14586