Skip to content

Merge 2.3.x into 2.2.x #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
staabm wants to merge 4 commits into from
Closed

Merge 2.3.x into 2.2.x #6429

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f857c2d
Do not report `?? null` / `??= null` as unnecessary when evaluating t…
phpstan-bot Sep 11, 2026
12b333b
Make the null-coalesce side-effect test data PHP version independent
phpstan-bot Sep 11, 2026
82b2c00
Cover every node kind checked by NullCoalesceRule::containsAssign()
phpstan-bot Sep 12, 2026
8a6d7e8
Fix bad merge
staabm Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cover every node kind checked by NullCoalesceRule::containsAssign() 
Only the plain `Assign` branch was exercised so far. Add one right side
per remaining node kind, each of them inferred as `null` so it reaches
the check: `=&`, a nested `+=`, and `++`/`--` in an array offset of an
`array<int, null>`.

Removing any single `instanceof` clause makes exactly one of these cases
report the false positive again.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
  • Loading branch information
@phpstan-bot @claude @staabm
2 people authored and staabm committed Sep 12, 2026
commit 82b2c004f87f08a910dea9de8271f49d7961c5a1
37 changes: 37 additions & 0 deletions tests/PHPStan/Rules/Variables/data/unnecessary-null-coalesce-side-effects.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,40 @@ function nullPropertyOnRightSide(Foo $foo, Foo $bar): ?string
{
return $foo->stringOrNull ?? $bar->alwaysNull;
}

function assignRefOnRightSide(Foo $foo): ?string
{
$null = null;

return $foo->stringOrNull ?? $ref = &$null;
}

/** @param array<int, null> $nulls */
function assignOpInOffsetOnRightSide(Foo $foo, array $nulls, int $i): ?string
{
return $foo->stringOrNull ?? $nulls[$i += 1];
}

/** @param array<int, null> $nulls */
function postIncOnRightSide(Foo $foo, array $nulls, int $i): ?string
{
return $foo->stringOrNull ?? $nulls[$i++];
}

/** @param array<int, null> $nulls */
function preIncOnRightSide(Foo $foo, array $nulls, int $i): ?string
{
return $foo->stringOrNull ?? $nulls[++$i];
}

/** @param array<int, null> $nulls */
function postDecOnRightSide(Foo $foo, array $nulls, int $i): ?string
{
return $foo->stringOrNull ?? $nulls[$i--];
}

/** @param array<int, null> $nulls */
function preDecOnRightSide(Foo $foo, array $nulls, int $i): ?string
{
return $foo->stringOrNull ?? $nulls[--$i];
}