Skip to content

Compare conditional expressions in MutatingScope::equals() #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 2 commits into from
Sep 8, 2026
Merged

Compare conditional expressions in MutatingScope::equals() #6344

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c17f621
Compare conditional expressions in MutatingScope::equals()
janedbal Sep 2, 2026
2f64ac5
Reduce the loop fixpoint regression fixture to its essential shape
janedbal Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reduce the loop fixpoint regression fixture to its essential shape 
Co-Authored-By: Claude Code
  • Loading branch information
@janedbal
janedbal committed Sep 2, 2026
commit 2f64ac522877c079db184abf8de4d954433697db
35 changes: 6 additions & 29 deletions tests/PHPStan/Analyser/nsrt/loop-fixpoint-conditional-expressions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,55 +2,32 @@

namespace LoopFixpointConditionalExpressions;

use LogicException;
use function PHPStan\Testing\assertType;

final class Item
{

public function assign(): void
{
}

}

abstract class Foo
class Foo
{

/** @return list<Item> */
abstract public function getItems(): array;

public function run(int $quantityToAllocate, int $unitsThatFit): void
/** @param list<Item> $items */
public function run(array $items): void
{
$items = $this->getItems();
if ($quantityToAllocate <= 0) {
return;
}
if ($unitsThatFit <= 0) {
return;
}

do {
$unitsAdded = min($unitsThatFit, $quantityToAllocate);
foreach ([1, 2] as $_) {
$toCurrent = 0;
if ($items !== []) {
$unitsAdded = min($unitsAdded, count($items));
$toCurrent = $unitsAdded;
$toCurrent = count($items);
}

while ($toCurrent > 0) {
assertType('list<LoopFixpointConditionalExpressions\Item>', $items);
$item = array_shift($items);
assertType('LoopFixpointConditionalExpressions\Item|null', $item);
if ($item === null) {
throw new LogicException();
}
$item->assign();
$toCurrent--;
}

$quantityToAllocate -= $unitsAdded;
} while ($quantityToAllocate > 0);
}
}

}
Loading