Skip to content

Fix flickering of trait errors deduplicated into the trait file #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mabar wants to merge 2 commits into from
Closed

Fix flickering of trait errors deduplicated into the trait file #6071

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c20ce3
Sort collected data before running CollectedDataNode rules
mabar Jul 21, 2026
339dcc0
Attribute deduplicated trait errors to the trait file
mabar Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Sort collected data before running CollectedDataNode rules
  • Loading branch information
@mabar
mabar committed Jul 21, 2026
commit 1c20ce30e110db4b977ca7c163585073b197b26a
5 changes: 4 additions & 1 deletion src/Analyser/AnalyserResultFinalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use function array_merge;
use function count;
use function get_class;
use function ksort;
use function sprintf;

#[AutowiredService]
Expand Down Expand Up @@ -44,7 +45,9 @@ public function finalize(AnalyserResult $analyserResult, bool $onlyFiles, bool $
}

$nodeType = CollectedDataNode::class;
$node = new CollectedDataNode($analyserResult->getCollectedData(), $onlyFiles);
$collectedData = $analyserResult->getCollectedData();
ksort($collectedData);
$node = new CollectedDataNode($collectedData, $onlyFiles);

$file = 'N/A';
$scope = $this->scopeFactory->create(ScopeContext::create($file));
Expand Down