Return TrinaryLogic from isPureUnlessCallableIsImpureParameter()

Per review: the parameter-level flag must be a TrinaryLogic so it composes correctly on union and intersection method variants (combineAcceptors uses ->or(), mirroring isImmediatelyInvokedCallable). Origins convert the bool from PHPDoc/metadata with TrinaryLogic::createFromBoolean(); the consumption in SimpleImpurePoint skips only parameters whose flag is ->no().
ondrejmirtes · Jul 7, 2026 · Jul 2, 2026 · Jul 2, 2026 · Jul 2, 2026 · Jul 2, 2026
commit 3ec51f139f7f44f883ac7a9f9600f425f198f24a
diff --git a/src/Reflection/Annotations/AnnotationsMethodParameterReflection.php b/src/Reflection/Annotations/AnnotationsMethodParameterReflection.php
@@ -92,9 +92,9 @@ public function checkAllowedConstants(array $constants): AllowedConstantsResult
 		return new AllowedConstantsResult([], [], false);
 	}
 
-	public function isPureUnlessCallableIsImpureParameter(): bool
+	public function isPureUnlessCallableIsImpureParameter(): TrinaryLogic
 	{
-		return false;
+		return TrinaryLogic::createNo();
 	}
 
 }
diff --git a/src/Reflection/Callables/SimpleImpurePoint.php b/src/Reflection/Callables/SimpleImpurePoint.php
@@ -148,7 +148,7 @@ public static function resolvePureUnlessCallableIsImpureVerdict(ParametersAccept
 			if (!$parameter instanceof ExtendedParameterReflection) {
 				continue;
 			}
-			if (!$parameter->isPureUnlessCallableIsImpureParameter()) {
+			if ($parameter->isPureUnlessCallableIsImpureParameter()->no()) {
 				continue;
 			}
 

diff --git a/src/Reflection/ExtendedParameterReflection.php b/src/Reflection/ExtendedParameterReflection.php
@@ -36,6 +36,6 @@ public function getAllowedConstants(): ?ParameterAllowedConstants;
 	 */
 	public function checkAllowedConstants(array $constants): AllowedConstantsResult;
 
-	public function isPureUnlessCallableIsImpureParameter(): bool;
+	public function isPureUnlessCallableIsImpureParameter(): TrinaryLogic;
 
 }
diff --git a/src/Reflection/GenericParametersAcceptorResolver.php b/src/Reflection/GenericParametersAcceptorResolver.php
@@ -132,6 +132,7 @@ public static function resolve(array $argTypes, ParametersAcceptor $parametersAc
 					null,
 					[],
 					null,
+					TrinaryLogic::createNo(),
 				), $parameters),
 				$parametersAcceptor->isVariadic(),
 				$returnType,

diff --git a/src/Reflection/Native/ExtendedNativeParameterReflection.php b/src/Reflection/Native/ExtendedNativeParameterReflection.php
@@ -31,7 +31,7 @@ public function __construct(
 		private ?Type $closureThisType,
 		private array $attributes,
 		private ?ParameterAllowedConstants $allowedConstants,
-		private bool $pureUnlessCallableIsImpureParameter = false,
+		private TrinaryLogic $pureUnlessCallableIsImpureParameter,
 	)
 	{
 	}
@@ -115,7 +115,7 @@ public function checkAllowedConstants(array $constants): AllowedConstantsResult
 		return $this->allowedConstants->check($constants);
 	}
 
-	public function isPureUnlessCallableIsImpureParameter(): bool
+	public function isPureUnlessCallableIsImpureParameter(): TrinaryLogic
 	{
 		return $this->pureUnlessCallableIsImpureParameter;
 	}

diff --git a/src/Reflection/ParametersAcceptorSelector.php b/src/Reflection/ParametersAcceptorSelector.php
@@ -768,7 +768,7 @@ public static function combineAcceptors(array $acceptors): ExtendedParametersAcc
 						$parameter instanceof ExtendedParameterReflection ? $parameter->getClosureThisType() : null,
 						$parameter instanceof ExtendedParameterReflection ? $parameter->getAttributes() : [],
 						$parameter instanceof ExtendedParameterReflection ? $parameter->getAllowedConstants() : null,
-						$parameter instanceof ExtendedParameterReflection && $parameter->isPureUnlessCallableIsImpureParameter(),
+						$parameter instanceof ExtendedParameterReflection ? $parameter->isPureUnlessCallableIsImpureParameter() : TrinaryLogic::createNo(),
 					);
 					continue;
 				}
@@ -824,7 +824,7 @@ public static function combineAcceptors(array $acceptors): ExtendedParametersAcc
 				}
 
 				$pureUnlessCallableIsImpureParameter = $parameters[$i]->isPureUnlessCallableIsImpureParameter()
-					|| ($parameter instanceof ExtendedParameterReflection && $parameter->isPureUnlessCallableIsImpureParameter());
+					->or($parameter instanceof ExtendedParameterReflection ? $parameter->isPureUnlessCallableIsImpureParameter() : TrinaryLogic::createNo());
 
 				$parameters[$i] = new ExtendedDummyParameter(
 					$parameters[$i]->getName() !== $parameter->getName() ? sprintf('%s|%s', $parameters[$i]->getName(), $parameter->getName()) : $parameter->getName(),
@@ -942,6 +942,7 @@ private static function wrapParameter(ParameterReflection $parameter): ExtendedP
 			null,
 			[],
 			null,
+			TrinaryLogic::createNo(),
 		);
 	}
 

diff --git a/src/Reflection/Php/ClosureCallMethodReflection.php b/src/Reflection/Php/ClosureCallMethodReflection.php
@@ -101,6 +101,7 @@ public function getVariants(): array
 					null,
 					// pure-unless-callable-is-impure is not threaded here: a closure's own
 					// parameters cannot carry the tag.
+					TrinaryLogic::createNo(),
 				), $parameters),
 				$this->closureType->isVariadic(),
 				$this->closureType->getReturnType(),

diff --git a/src/Reflection/Php/ExitFunctionReflection.php b/src/Reflection/Php/ExitFunctionReflection.php
@@ -60,6 +60,7 @@ public function getVariants(): array
 						null,
 						[],
 						null,
+						TrinaryLogic::createNo(),
 					),
 				],
 				false,

diff --git a/src/Reflection/Php/ExtendedDummyParameter.php b/src/Reflection/Php/ExtendedDummyParameter.php
@@ -31,7 +31,7 @@ public function __construct(
 		private ?Type $closureThisType,
 		private array $attributes,
 		private ?ParameterAllowedConstants $allowedConstants,
-		private bool $pureUnlessCallableIsImpureParameter = false,
+		private TrinaryLogic $pureUnlessCallableIsImpureParameter,
 	)
 	{
 		parent::__construct($name, $type, $optional, $passedByReference, $variadic, $defaultValue);
@@ -86,7 +86,7 @@ public function checkAllowedConstants(array $constants): AllowedConstantsResult
 		return $this->allowedConstants->check($constants);
 	}
 
-	public function isPureUnlessCallableIsImpureParameter(): bool
+	public function isPureUnlessCallableIsImpureParameter(): TrinaryLogic
 	{
 		return $this->pureUnlessCallableIsImpureParameter;
 	}

diff --git a/src/Reflection/Php/PhpClassReflectionExtension.php b/src/Reflection/Php/PhpClassReflectionExtension.php
@@ -1067,6 +1067,7 @@ private function createNativeMethodVariant(
 				$this->allowedConstantsMapProvider->getForMethodParameter($declaringClassName, $methodName, $parameterSignature->getName()),
 				// pure-unless-callable-is-impure is not threaded here because no built-in method
 				// carries it (there are no Class::method entries in functionMetadata.php).
+				TrinaryLogic::createNo(),
 			);
 		}
 

diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -179,7 +179,7 @@ public function getParameters(): array
 				$closureThisType = null;
 			}
 
-			$pureUnlessCallableIsImpureParameter = $this->pureUnlessCallableIsImpureParameters[$parameter->var->name] ?? false;
+			$pureUnlessCallableIsImpureParameter = TrinaryLogic::createFromBoolean($this->pureUnlessCallableIsImpureParameters[$parameter->var->name] ?? false);
 
 			$parameters[] = new PhpParameterFromParserNodeReflection(
 				$parameter->var->name,

diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -132,7 +132,7 @@ private function getParameters(): array
 				$this->phpDocParameterClosureThisTypes[$reflection->getName()] ?? null,
 				$this->attributeReflectionFactory->fromNativeReflection($reflection->getAttributes(), InitializerExprContext::fromReflectionParameter($reflection)),
 				$this->allowedConstantsMapProvider->getForFunctionParameter(strtolower($this->reflection->getName()), $reflection->getName()),
-				$this->phpDocParameterPureUnlessCallableIsImpure[$reflection->getName()] ?? false,
+				TrinaryLogic::createFromBoolean($this->phpDocParameterPureUnlessCallableIsImpure[$reflection->getName()] ?? false),
 			);
 		}, $this->reflection->getParameters());
 	}

diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -231,7 +231,7 @@ private function getParameters(): array
 			$this->phpDocClosureThisTypeParameters[$reflection->getName()] ?? null,
 			$this->attributeReflectionFactory->fromNativeReflection($reflection->getAttributes(), InitializerExprContext::fromReflectionParameter($reflection)),
 			$this->allowedConstantsMapProvider->getForMethodParameter($this->declaringClass->getName(), $this->reflection->getName(), $reflection->getName()),
-			$this->pureUnlessCallableIsImpureParameters[$reflection->getName()] ?? false,
+			TrinaryLogic::createFromBoolean($this->pureUnlessCallableIsImpureParameters[$reflection->getName()] ?? false),
 		), $this->reflection->getParameters());
 	}
 

diff --git a/src/Reflection/Php/PhpParameterFromParserNodeReflection.php b/src/Reflection/Php/PhpParameterFromParserNodeReflection.php
@@ -33,7 +33,7 @@ public function __construct(
 		private TrinaryLogic $immediatelyInvokedCallable,
 		private ?Type $closureThisType,
 		private array $attributes,
-		private bool $pureUnlessCallableIsImpureParameter,
+		private TrinaryLogic $pureUnlessCallableIsImpureParameter,
 	)
 	{
 	}
@@ -126,7 +126,7 @@ public function checkAllowedConstants(array $constants): AllowedConstantsResult
 		return new AllowedConstantsResult([], [], false);
 	}
 
-	public function isPureUnlessCallableIsImpureParameter(): bool
+	public function isPureUnlessCallableIsImpureParameter(): TrinaryLogic
 	{
 		return $this->pureUnlessCallableIsImpureParameter;
 	}

diff --git a/src/Reflection/Php/PhpParameterReflection.php b/src/Reflection/Php/PhpParameterReflection.php
@@ -37,7 +37,7 @@ public function __construct(
 		private ?Type $closureThisType,
 		private array $attributes,
 		private ?ParameterAllowedConstants $allowedConstants,
-		private bool $pureUnlessCallableIsImpureParameter = false,
+		private TrinaryLogic $pureUnlessCallableIsImpureParameter,
 	)
 	{
 	}
@@ -161,7 +161,7 @@ public function checkAllowedConstants(array $constants): AllowedConstantsResult
 		return $this->allowedConstants->check($constants);
 	}
 
-	public function isPureUnlessCallableIsImpureParameter(): bool
+	public function isPureUnlessCallableIsImpureParameter(): TrinaryLogic
 	{
 		return $this->pureUnlessCallableIsImpureParameter;
 	}

diff --git a/src/Reflection/SignatureMap/NativeFunctionReflectionProvider.php b/src/Reflection/SignatureMap/NativeFunctionReflectionProvider.php
@@ -133,7 +133,7 @@ public function findFunctionReflection(string $functionName): ?NativeFunctionRef
 						$phpDocType = null;
 						$immediatelyInvokedCallable = TrinaryLogic::createMaybe();
 						$closureThisType = null;
-						$pureUnlessCallableIsImpureParameter = $pureUnlessCallableIsImpureParameters[$name] ?? false;
+						$pureUnlessCallableIsImpureParameter = TrinaryLogic::createFromBoolean($pureUnlessCallableIsImpureParameters[$name] ?? false);
 						if ($phpDoc !== null) {
 							if (array_key_exists($parameterSignature->getName(), $phpDoc->getParamTags())) {
 								$phpDocType = $phpDoc->getParamTags()[$parameterSignature->getName()]->getType();
@@ -145,7 +145,7 @@ public function findFunctionReflection(string $functionName): ?NativeFunctionRef
 								$closureThisType = $phpDoc->getParamClosureThisTags()[$parameterSignature->getName()]->getType();
 							}
 							if (($phpDoc->getParamsPureUnlessCallableIsImpure()[$parameterSignature->getName()] ?? false) === true) {
-								$pureUnlessCallableIsImpureParameter = true;
+								$pureUnlessCallableIsImpureParameter = TrinaryLogic::createYes();
 							}
 						}
 

diff --git a/src/Reflection/WrappedExtendedMethodReflection.php b/src/Reflection/WrappedExtendedMethodReflection.php
@@ -78,6 +78,7 @@ public function getVariants(): array
 					null,
 					[],
 					null,
+					TrinaryLogic::createNo(),
 				), $variant->getParameters()),
 				$variant->isVariadic(),
 				$variant->getReturnType(),

diff --git a/tests/PHPStan/Reflection/ParametersAcceptorSelectorTest.php b/tests/PHPStan/Reflection/ParametersAcceptorSelectorTest.php
@@ -93,6 +93,7 @@ public static function dataSelectFromTypes(): Generator
 					$parameter->getClosureThisType(),
 					$parameter->getAttributes(),
 					$parameter->getAllowedConstants(),
+					$parameter->isPureUnlessCallableIsImpureParameter(),
 				), $datePeriodConstructorVariants[0]->getParameters()),
 				false,
 				new VoidType(),
@@ -125,6 +126,7 @@ public static function dataSelectFromTypes(): Generator
 					$parameter->getClosureThisType(),
 					$parameter->getAttributes(),
 					$parameter->getAllowedConstants(),
+					$parameter->isPureUnlessCallableIsImpureParameter(),
 				), $datePeriodConstructorVariants[1]->getParameters()),
 				false,
 				new VoidType(),
-Original file line number
+Diff line change
@@ Expand Up / @@ -60,6 +60,7 @@ public function getVariants(): array @@
     						null,
     						[],
     						null,
+    						TrinaryLogic::createNo(),
     					),
     				],
     				false,
@@ Expand Down @@