Skip to content

Type projections, part 3: call-site restrictions #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 8 commits into from
Sep 18, 2023
Merged

Type projections, part 3: call-site restrictions #2485

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01131e8
type projections: enhance template type resolution
jiripudil Jul 21, 2023
5597a68
implement Type::traverseWithVariance()
jiripudil Jun 23, 2023
219b16d
call TemplateTypeHelper::resolveTemplateTypes() with call-site varian…
jiripudil Jun 23, 2023
3f3151d
skip lint on older PHP versions
jiripudil Jun 23, 2023
25d4172
fix GetTemplateTypeType::traverseWithVariance implementation
jiripudil Sep 1, 2023
4ce4f71
fix ArrayType traversal
jiripudil Sep 1, 2023
1077167
remove BC break from ParametersAcceptor
jiripudil Sep 16, 2023
2e8f508
simplify type projections resolution so that it does not need a new m…
jiripudil Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix ArrayType traversal 
preserve array<*NEVER*, *NEVER*> -> array{} conversion
  • Loading branch information
@jiripudil
jiripudil committed Sep 18, 2023
commit 4ce4f711bd197343b781c41b918fdc983f3fa0d0
4 changes: 4 additions & 0 deletions src/Type/ArrayType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,10 @@ public function traverseWithVariance(TemplateTypeVariance $variance, callable $c
return $this;
}

if ($newKeyType instanceof NeverType && $newItemType instanceof NeverType) {
return new ConstantArrayType([], []);
}

return new self($newKeyType, $newItemType);
}

Expand Down