UnhandledMatchError since 2.1.41

Bug report

Affected Version:

= 2.1.41

Problem:
Using a match expression, covering all possible options leads to an error, when it is used inside a foreach loop.
Running the same match expression on a single item, the error is gone.

Interstingly the error is gone, enabling "treatPhpDocTypesAsCertain"

Code snippet that reproduces the problem

https://phpstan.org/r/f6ae2fe6-cd75-4191-a7c8-96bfa4714b35

Expected output

I would expect no error to happen.

Did PHPStan help you today? Did it make you happy in any way?

No response

Fix phpstan/phpstan#14396: False UnhandledMatchError in foreach with …

Interstingly the error is gone, enabling "treatPhpDocTypesAsCertain"

That should help you to understand the reason.

If you don't trust your phpdoc, you cannot be sure the element are really instanceof Item. Then you cannot be sure ->status is really A, B, C or null.
I could put some

class Item2 {
    public function __construct(
        public Status|int|null $status
    ) {}
}

in the array and pass them to this method.

You solve the issue with an instanceof check:
https://phpstan.org/r/09768752-f3c5-4b49-aa12-31e2fc635c7a

That should help you to understand the reason.
I understand the reason.
And i understand that instance of check is fixing it

But i didnt read that the behaviour of treatPhpDocTypesAsCertain changed with your bugfix.
In addition the behaviour shouldnt be intended like this, since its rather inconsistent.

Shouldnt be the behaviour consistent along all phpstan checks?

Especially because:

before 2.1.41 it worked like this
i would assume, that more checks are failing in this example. (https://phpstan.org/r/847c1891-dd58-40f7-b0ae-65399b24b668)

If the type is not inferred from the docs, fine - but then i dont understand why it is expected, that the UnhandleMatchError occurs, but it is not expected that Cannot access property x on mixed. occurs.

Considering the change in a patch version within a bugfix its still a bug from my point of view, especially due to inconsistency with other checks

Feels like a bug. I don't get why we don't get "Match expression does not handle remaining..." error in either case, but we only get uncaught exception when the match is in a foreach. Really weird.

Feels like a bug. I don't get why we don't get "Match expression does not handle remaining..." error in either case, but we only get uncaught exception when the match is in a foreach. Really weird.

The MatchExpressionRule only use getType https://github.com/phpstan/phpstan-src/blob/dc813fe0538dd7edad72449f86f2ca35c769adbb/src/Rules/Comparison/MatchExpressionRule.php#L145
so maybe getNativeType should be used here.

On the other side the MatchHandler rely on the threatPhpDocAsCertain https://github.com/phpstan/phpstan-src/blob/dc813fe0538dd7edad72449f86f2ca35c769adbb/src/Analyser/ExprHandler/MatchHandler.php#L403

to report an always true condition
to know if the checks are exhaustive

Since the threatPhpDocAsCertain config is expected to be here to avoid false-positive error reported by PHPStan, I think we should add consistency by not making the throw point relying on the threatPhpDocAsCertain option.

Add regression test for #14396

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Navigation Menu

Repository navigation

UnhandledMatchError since 2.1.41 #14396

Bug report

Code snippet that reproduces the problem

Expected output

Did PHPStan help you today? Did it make you happy in any way?

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

UnhandledMatchError since 2.1.41 #14396

Description

Bug report

Code snippet that reproduces the problem

Expected output

Did PHPStan help you today? Did it make you happy in any way?

Activity

VincentLanglet commented on Mar 29, 2026

florianhofsaessC24 commented on Mar 29, 2026

ondrejmirtes commented on Mar 29, 2026

VincentLanglet commented on Mar 29, 2026

17 remaining items

github-actions commented on Oct 4, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions