Conversation
Member
|
Good catch. To be safe we probably have to dever merging this until we are preparing v7.0 as it is technicall BC. I already accidentally broke BC in 6.1.0 and don't want to do that again. 😅 |
michael-grunder
added
breaking change
major-version-bump
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stub is currently defined as
however the underlying function expects ints
phpredis/redis_cluster.c
Lines 1392 to 1397 in abb0f6c
I re-ran gen_stub.php which updated some other stuff.
doctum fatals with my local version of PHP so I didn't update docs.