Skip to content

Fix ColumnsDefinition - #20503

Open
kamil-tekiela wants to merge 3 commits into
phpmyadmin:masterfrom
kamil-tekiela:Fix-ColumnsDefinition
Open

Fix ColumnsDefinition#20503
kamil-tekiela wants to merge 3 commits into
phpmyadmin:masterfrom
kamil-tekiela:Fix-ColumnsDefinition

Conversation

@kamil-tekiela

@kamil-tekiela kamil-tekiela commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Fixes "Using null as an array offset is deprecated, use an empty string instead" and missing input_transformation

@codecov

codecov Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.15385% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.17%. Comparing base (34eb839) to head (644ff4c).

Files with missing lines Patch % Lines
src/Table/ColumnsDefinition.php 38.23% 21 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #20503      +/-   ##
============================================
- Coverage     64.18%   64.17%   -0.01%     
- Complexity    16082    16083       +1     
============================================
  Files           678      678              
  Lines         57824    57822       -2     
============================================
- Hits          37117    37110       -7     
- Misses        20707    20712       +5
Flag Coverage Δ
dbase-extension 64.16% <46.15%> (-0.02%) ⬇️
unit-8.2-ubuntu-latest 64.14% <46.15%> (-0.01%) ⬇️
unit-8.3-ubuntu-latest 64.09% <46.15%> (-0.06%) ⬇️
unit-8.4-ubuntu-latest 64.14% <46.15%> (-0.02%) ⬇️
unit-8.5-ubuntu-latest 64.14% <46.15%> (+0.05%) ⬆️
unit-8.6-ubuntu-latest 64.07% <46.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kamil-tekiela
kamil-tekiela marked this pull request as draft September 29, 2026 22:27
@kamil-tekiela
Fix ColumnsDefinition
d20135b 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@kamil-tekiela

kamil-tekiela commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

So it turns out that this template is also used my Normalization, but Normalization is currently so broken that I cannot test it or figure out what the actual behaviour is supposed to be.

@kamil-tekiela
Clean up StructureController
32dc9f7 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@kamil-tekiela
kamil-tekiela force-pushed the Fix-ColumnsDefinition branch from 55ed9af to 2c8fe99 Compare October 1, 2026 15:04
@kamil-tekiela
kamil-tekiela marked this pull request as ready for review October 1, 2026 15:04
@kamil-tekiela

kamil-tekiela commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

I honestly don't know if it's 100% correct. These complex templates are really messing with my brain. I was also not able to fully test the Normalization path. I think this should fix the initial problem when adding another row to the table creation dialog.

@kamil-tekiela
Remove unused variables from normalization
644ff4c 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@kamil-tekiela
kamil-tekiela force-pushed the Fix-ColumnsDefinition branch from 2c8fe99 to 644ff4c Compare October 1, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kamil-tekiela