Conversation
Signed-off-by: Om Kolte <26180402+omkolte17@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## QA_5_2 #20491 +/- ##
============================================
+ Coverage 50.12% 50.43% +0.31%
- Complexity 17249 17261 +12
============================================
Files 607 607
Lines 68276 68300 +24
============================================
+ Hits 34221 34446 +225
+ Misses 34055 33854 -201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Column metadata reports the effective collation even when a column inherits it from the table. The edit form previously treated that value as an explicit column choice, so changing another property added a
COLLATEclause.Use
SHOW CREATE TABLEto distinguish inherited settings from explicit columnCOLLATEor character set clauses. Leave the collation choice blank for inherited columns, preserve explicit settings, and retain the prior behavior if the table definition cannot be parsed.Fixes #20411
Verification
QA_5_2build, changed an inheritedVARCHARcolumn fromNOT NULLtoNULLthrough phpMyAdmin. The generatedALTER TABLEcontained noCOLLATEclause, andSHOW CREATE TABLEstill showed no column collation clause.The commit includes the required DCO sign-off.