Skip to content

fix: preserve geometry display for joined results - #20466

Open
mvanhorn wants to merge 1 commit into
phpmyadmin:masterfrom
mvanhorn:fix/20430-geometry-joined-results
Open

mvanhorn wants to merge 1 commit into
phpmyadmin:masterfrom
mvanhorn:fix/20430-geometry-joined-results

Conversation

@mvanhorn

@mvanhorn mvanhorn commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Description

Decouple geometry presentation from row editability by removing the possible_as_geometry session value written by Sql and the DisplayResults fallback that replaces GEOM with WKT for non-editable results. Render the Geometry radio option unconditionally and remove the obsolete option data passed to the Twig template, while leaving edit/delete-link eligibility unchanged. Update the existing result-rendering expectations and multi-table query fixture to reflect the always-available Geometry choice.

A geometry column is normally rendered as a compact [GEOMETRY - N B] value, but a query containing a join is classified as non-editable and silently switches the geometry display mode to WKT. That exposes the full polygon text even when partial-text display is active. The editability decision is valid for row action links, but it is unrelated to whether a result value can be rendered in the compact geometry mode. The issue includes a reproducible schema and query, and the thread identifies the possible_as_geometry gate as the cause.

Fixes #20430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Geometry column not truncated when table is joined

2 participants