Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decouple geometry presentation from row editability by removing the
possible_as_geometrysession value written bySqland theDisplayResultsfallback that replacesGEOMwithWKTfor non-editable results. Render the Geometry radio option unconditionally and remove the obsolete option data passed to the Twig template, while leaving edit/delete-link eligibility unchanged. Update the existing result-rendering expectations and multi-table query fixture to reflect the always-available Geometry choice.A geometry column is normally rendered as a compact
[GEOMETRY - N B]value, but a query containing a join is classified as non-editable and silently switches the geometry display mode to WKT. That exposes the full polygon text even when partial-text display is active. The editability decision is valid for row action links, but it is unrelated to whether a result value can be rendered in the compact geometry mode. The issue includes a reproducible schema and query, and the thread identifies thepossible_as_geometrygate as the cause.Fixes #20430