Skip to content

Fix #20453 - Fix SkipLockedTables not showing tables in database - #20454

Draft
liviuconcioiu wants to merge 1 commit into
phpmyadmin:masterfrom
liviuconcioiu:20453
Draft

liviuconcioiu wants to merge 1 commit into
phpmyadmin:masterfrom
liviuconcioiu:20453

Conversation

@liviuconcioiu

@liviuconcioiu liviuconcioiu commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Description

Before:

Database with no locked tables:

before1

Database with a locked table:

before2

After - $cfg['SkipLockedTables'] = true;

after

After - $cfg['SkipLockedTables'] = false;

after2

Fixes #20453

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
@codecov

codecov Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.76%. Comparing base (aff60b1) to head (25eed3a).
⚠️ Report is 153 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20454      +/-   ##
============================================
- Coverage     63.77%   63.76%   -0.01%     
- Complexity    16118    16121       +3     
============================================
  Files           676      676              
  Lines         58001    58008       +7     
============================================
  Hits          36989    36989              
- Misses        21012    21019       +7     
Flag Coverage Δ
dbase-extension 63.69% <ø> (-0.01%) ⬇️
unit-8.2-ubuntu-latest 63.68% <ø> (-0.01%) ⬇️
unit-8.3-ubuntu-latest 63.72% <ø> (-0.02%) ⬇️
unit-8.4-ubuntu-latest 63.70% <ø> (-0.04%) ⬇️
unit-8.5-ubuntu-latest 63.72% <ø> (-0.02%) ⬇️
unit-8.6-ubuntu-latest 63.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liviuconcioiu

Copy link
Copy Markdown
Contributor Author

To test it, lock a table:

LOCK TABLE `table` WRITE;

@liviuconcioiu
liviuconcioiu marked this pull request as draft August 25, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.0]: SkipLockedTables shows No tables found in database.

1 participant