Conversation
Browsers dropped the XSS auditor this header controlled, and OWASP now says not to send it. Removed it from Header::getHttpHeaders() and updated the unit test. Fixes phpmyadmin#18749 Signed-off-by: Pongoe <pongoe@users.noreply.github.com>
williamdes
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20427 +/- ##
============================================
- Coverage 63.79% 63.76% -0.04%
Complexity 16122 16122
============================================
Files 676 676
Lines 58014 58009 -5
============================================
- Hits 37012 36990 -22
- Misses 21002 21019 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kamil-tekiela
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18749
I noticed this had been sitting open since 2023 and it looked like a quick one, so I've done it.
The XSS auditor this header controlled is gone from all the major browsers, and OWASP now
says not to send it at all:
https://cheatsheetseries.owasp.org/cheatsheets/HTTP_Headers_Cheat_Sheet.html#x-xss-protection
What I changed:
src/Header.phptests/unit/HeaderTest.phpCHANGELOG-6.0.mdunder RemovedHeaderTest passes and phpcs is clean on both files. This is against master.
Cheers