Conversation
Move doctrine/annotations to require-dev and suggest. Without it the annotation reader throws a helpful error when it finds PHPBench annotations instead of silently ignoring them. The PHAR still bundles the package. Closes phpbench#1068 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
this would be a B/C break. the only clean way to do this would be in PHPBench 2.x is there a concrete problem that having this dependency has for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1068
doctrine/annotationsis abandoned and PHP attributes are fully supported, so this makes the package optional:doctrine/annotationsfromrequiretorequire-devand add it tosuggest.AnnotationReaderworks without Doctrine. If it finds a PHPBench annotation, it throws aCouldNotLoadMetadataExceptionthat says how to fix it (install the package, migrate to attributes, or disablerunner.annotations). It does not ignore the annotation silently. Detection follows theDocParserrules: case-insensitive names, and an@preceded by whitespace,*or nothing. Withrunner.annotation_import_usethe reader detects theuse PhpBench\Benchmark\Metadata\Annotations...import, because aliases can be anything.doctrine/annotations: the release workflow adds it before compiling.The constructor takes a new optional
?bool $doctrineAvailableargument (auto-detected whennull), so the no-Doctrine path can be unit tested.🤖 Generated with Claude Code