Conversation
dantleech
force-pushed
the
json
branch
3 times, most recently
from
March 7, 2026 11:32
0e75662 to
2a77b64
Compare
Contributor
|
@dantleech I've just tested the PHAR distribution of version 1.6.0 and got error with yq tool. /shared/backups/phar/phpbench-1.6.phar run --progress=json --config=/shared/backups/github/phplint/phpbench.json tests/Benchmark/ | yq -o jsonOr with yq auto-detecting format /shared/backups/phar/phpbench-1.6.phar run --progress=json --config=/shared/backups/github/phplint/phpbench.json tests/Benchmark/ | yqWhen I specify Any idea about incompatibility ? |
Member
Author
|
maybe try it with |
Member
Author
|
I get the same error with Using |
Contributor
|
I got very strange results/behavior on project https://github.com/overtrue/phplint where I am a contributor since a long time now ! Here is the full benchmark test suite running with only 1 iteration (as suggested in your previous comment) 
And if I remove the 
Is there something we could do to prevent such failure ? |
Contributor
|
Related to #1136 (comment), I've try to apply it with : My {
"report.generators": {
"github-action-benchmark": {
"cols": [
"name",
"unit",
"value",
"range",
"extra"
],
"expressions": {
"name": "format('%s::%s%s', first(benchmark_name),first(subject_name),if(first(variant_name) != false, format(' (%s)', first(variant_name)), ''))",
"unit": "coalesce(time_unit(first(subject_time_unit), true),'µs')",
"value": "time_convert(mode(result_time_avg), 'us', time_unit(first(subject_time_unit)))",
"range": "format('± %.2f%%', rstdev(result_time_avg))",
"extra": "format('%d iterations, %d revs', first(variant_iterations), first(variant_revs))"
},
"aggregate": [
"suite_tag",
"benchmark_class",
"subject_name",
"variant_index"
],
"generator": "expression"
}
},
"runner.bootstrap": "autoload.php",
"runner.php_disable_ini": true
}But, if I run full benchmarks tests (including 
What was wrong in such condition ? |
Member
Author
this is a problem with phplint opening too many files - I don't think it's related to PHPBench. See https://stackoverflow.com/questions/14748499/fatal-error-too-many-open-files |
Member
Author
Plase comment on the original PR or open an issue :) but you don't need to specify |
Contributor
|
Thanks @dantleech : Changing the maximum number of open file descriptors with phpbench run --report=github-action-benchmark --progress=json --output json tests/Benchmark/ | yq -p jsonGave me : last chunk of progress json was displayed, and final report 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for streaming results via. a JSON progress logger: