Conversation
|
The attempt to merge branch
This PR is ready to be merged. |
…e_after core.ucp_pm_compose_modify_parse_after already fires at exactly the right point for validating a PM before it is sent, and already exposes error and submit. It does not expose address_list, the recipient list already fully built earlier in the same function, so a listener can reject a PM but cannot inspect who it is actually being sent to. Adds address_list (array, read-only) to the event's vars and docblock. No new event, no change to where this fires. PHPBB-17723
bonelifer
force-pushed
the
ticket/17723
branch
from
October 1, 2026 20:43
8413d6d to
7d5e14a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17723
Adds
address_list(array, read-only) to the existingcore.ucp_pm_compose_modify_parse_afterevent's vars and docblock. The recipient list is already fully built earlier in the same function; this just exposes it to listeners that already use this event to validate a PM before it's sent, but currently can't see who it's addressed to. No new event, no change to where it fires — see the linked ticket for the full use case.