Conversation
phpBB/composer.lockPackage changes
Dev Package changes
Settings · Docs · Powered by Private Packagist |
CHItA
force-pushed
the
ticket/17197
branch
2 times, most recently
from
September 18, 2026 15:13
6fd4028 to
082ae9e
Compare
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
CHItA
force-pushed
the
ticket/17197
branch
2 times, most recently
from
September 18, 2026 16:13
b60c509 to
b4d2f0c
Compare
PHPBB3-17197
CHItA
added
4.0 (Triton) 🔮
dependencies
marc1706
reviewed
Sep 19, 2026
marc1706
reviewed
Sep 19, 2026
Member
There was a problem hiding this comment.
Add a migration to remove the twitter oauth settings from the config
Member
Author
There was a problem hiding this comment.
I think it should be included in the migration - but will double check.
marc1706
reviewed
Sep 27, 2026
marc1706
left a comment
marc1706
left a comment
Member
There was a problem hiding this comment.
I think the lang string in common.php for the twitter oauth provider can also be removed now. Did you already tests this against google, etc. if oauth still works?
| "doctrine/dbal": "^4.4", | ||
| "google/recaptcha": "~1.1", | ||
| "guzzlehttp/guzzle": " ^7.0", | ||
| "league/oauth2-client": "2.*", |
Member
There was a problem hiding this comment.
How about something like
Suggested change
| "league/oauth2-client": "2.*", | |
| "league/oauth2-client": "^2.8", |
or even 2.9
| <value>897a897b797c8789997d7979879</value> | ||
| <value>auth.provider.oauth.service.google</value> | ||
| <value>{"accessToken":"ya29.YPHwCWVkrvwu1kgbYKiDNYaQ451ZuHy9OEQAGVME8if-WBzR-v7a9ftxbx41kaL)5VLEXB-6qJEvri","endOfLife":1429959670,"extraParams":{"token_type":"Bearer","id_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"},"refreshToken":null,"token_class":"OAuth\\\\OAuth2\\\\Token\\\\StdOAuth2Token"}</value> | ||
| <value>{"access_token":"ya29.YPHwCWVkrvwu1kgbYKiDNYaQ451ZuHy9OEQAGVME8if-WBzR-v7a9ftxbx41kaL)5VLEXB-6qJEvri","expires":1429959670,"refresh_token":null,"values":{"token_type":"Bearer","id_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"}}}</value> |
Member
There was a problem hiding this comment.
Suggested change
| <value>{"access_token":"ya29.YPHwCWVkrvwu1kgbYKiDNYaQ451ZuHy9OEQAGVME8if-WBzR-v7a9ftxbx41kaL)5VLEXB-6qJEvri","expires":1429959670,"refresh_token":null,"values":{"token_type":"Bearer","id_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"}}}</value> | |
| <value>{"access_token":"ya29.YPHwCWVkrvwu1kgbYKiDNYaQ451ZuHy9OEQAGVME8if-WBzR-v7a9ftxbx41kaL)5VLEXB-6qJEvri","expires":1429959670,"refresh_token":null,"values":{"token_type":"Bearer","id_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"}}</value> |
| $credentials = $this->get_service_credentials(); | ||
|
|
||
| return [ | ||
| 'clientId' => $credentials['key'], |
Member
There was a problem hiding this comment.
Erm, those don't seem to be the same as the generic provider getRequiredOptions?
Member
There was a problem hiding this comment.
So for base get_provider() it will always throw. is there even a point of having the base method then?
| * @var AbstractProvider service OAuth service | ||
| * @since 3.2.3-RC1 | ||
| * @changed 3.2.6-RC1 Added redirect_data | ||
| * @psalm-var string[] $vars |
Member
There was a problem hiding this comment.
maybr add a changed here since this is no longer the same type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPBB3-17197
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-12345