Skip to content

[ticket/17716] Avoid SQL error when tracking empty files array in fil… #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubencm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ticket/17716] Avoid SQL error when tracking empty files array in fil… #7041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[ticket/17716] Avoid SQL error when tracking empty files array in fil… 
…e_tracker

Return early in file_tracker::track_files() if the files array is
empty, avoiding invalid SQL generation in sql_multi_insert.

PHPBB-17716
  • Loading branch information
@rubencm
rubencm committed Sep 17, 2026
commit ff1fe3a00fd05b2c666996f2502cfd63855ca5c5
5 changes: 5 additions & 0 deletions phpBB/phpbb/storage/file_tracker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ public function track_file(string $storage, string $path, int $size): void
*/
public function track_files(string $storage, array $files): void
{
if (empty($files))
{
return;
}

$sql_ary = [];
foreach ($files as $file)
{
Expand Down
Loading