Skip to content

Incremental text document updates #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dantleech merged 5 commits into from
Sep 19, 2026
Merged

Incremental text document updates #3010

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd1eb03
Use incremental text edit updates
dantleech Dec 29, 2025
f22cc7f
Fix application
dantleech Dec 30, 2025
75cd181
Make sync configurable
dantleech Sep 19, 2026
6b54803
Support full sync
dantleech Sep 19, 2026
631612a
EWorkspaceListenernsure workspace listener indexes incremental updates
dantleech Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make sync configurable
  • Loading branch information
@dantleech
dantleech committed Sep 19, 2026
commit 75cd181fc493b59705b3b126eec1893663d5acf1
19 changes: 15 additions & 4 deletions lib/Extension/LanguageServer/LanguageServerExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
use Phpactor\LanguageServer\Core\Dispatcher\ArgumentResolver;
use Phpactor\LanguageServer\Handler\Workspace\DidChangeWatchedFilesHandler;
use Phpactor\LanguageServer\Listener\DidChangeWatchedFilesListener;
use Phpactor\LanguageServer\Listener\WorkspaceListener;
use Phpactor\LanguageServer\Middleware\HandlerMiddleware;
use Phpactor\LanguageServer\Core\Server\ResponseWatcher;
use Phpactor\LanguageServer\Middleware\ResponseHandlingMiddleware;
Expand Down Expand Up @@ -100,6 +101,7 @@ class LanguageServerExtension implements Extension
public const SERVICE_LANGUAGE_SERVER_BUILDER = 'language_server.builder';
public const SERVICE_EVENT_EMITTER = 'language_server.event_emitter';
public const SERVICE_SESSION_WORKSPACE = 'language_server.session.workspace';
public const SERVICE_TEXT_DOCUMENT_SYNC_LISTENER = 'language_server.text_document_sync_listener';
public const TAG_METHOD_HANDLER = 'language_server.session_handler';
public const TAG_COMMAND = 'language_server.command';
public const TAG_SERVICE_PROVIDER = 'language_server.service_provider';
Expand Down Expand Up @@ -134,6 +136,7 @@ class LanguageServerExtension implements Extension
public const PARAM_DIAGNOSTIC_EXCLUDE_PATHS = 'language_server.diagnostic_exclude_paths';
public const PARAM_DIAGNOSTIC_IGNORE_CODES = 'language_server.diagnostic_ignore_codes';
public const PARAM_ENABLE_TRUST_CHECK = 'language_server.enable_trust_check';
public const PARAM_TEXT_DOCUMENT_SYNC = TextDocumentSyncKind::FULL;

public function configure(Resolver $schema): void
{
Expand Down Expand Up @@ -303,10 +306,18 @@ private function registerSession(ContainerBuilder $container): void
self::TAG_LISTENER_PROVIDER => [],
]);

$container->register(IncrementalUpdateListener::class, function (Container $container) {
return new IncrementalUpdateListener(
$container->expect(self::SERVICE_SESSION_WORKSPACE, Workspace::class),
);
$container->register(self::SERVICE_TEXT_DOCUMENT_SYNC_LISTENER, function (Container $container) {
if ($container->parameter(self::PARAM_ENABLE_WORKPACE)->bool() === false) {
return null;
}

if ($container->parameter(self::PARAM_TEXT_DOCUMENT_SYNC) === TextDocumentSyncKind::INCREMENTAL) {
return new IncrementalUpdateListener(
$container->expect(self::SERVICE_SESSION_WORKSPACE, Workspace::class),
);
}

return new WorkspaceListener($this->workspace($container));
}, [
self::TAG_LISTENER_PROVIDER => [],
]);
Expand Down