Skip to content

gh-2706: Switch to PHPStan docblock parser #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bart-jaskulski wants to merge 29 commits into
base: master
Choose a base branch
from
Open

gh-2706: Switch to PHPStan docblock parser #2759

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
9cd6143
gh-2706: Switch to PHPStan docblock parser
bart-jaskulski Oct 11, 2024
563d374
Misc fixes and improvements of phpstan parser integration
bart-jaskulski Oct 14, 2024
4c7cab9
Add support for rendering docblock with phpstan
bart-jaskulski Nov 1, 2024
bc446bc
Extract common functionality and provide "basic" strategy
bart-jaskulski Nov 1, 2024
6ad0438
Minor fixes in phpstan docblock parsing
bart-jaskulski Nov 1, 2024
f212fd6
Changes in tests for phpstan compatibility (breaks default docblock p…
bart-jaskulski Nov 1, 2024
c898ac8
Attempt to make UnusedImportProvider work with phpstan
bart-jaskulski Nov 1, 2024
4f7bc19
Fix unhandled match case
bart-jaskulski Nov 1, 2024
4b6ee72
Support parsing multiple docblocks from one text fragment
bart-jaskulski Nov 2, 2024
126fe57
Change expected test result for phpstan doc parser
bart-jaskulski Nov 6, 2024
041101e
Grouping with phpstan/doc-parser is not simple task
bart-jaskulski Nov 7, 2024
2e01a58
Remove trimming of content -- handled by parent template
bart-jaskulski Nov 7, 2024
724495e
Get rid of unused method
bart-jaskulski Nov 7, 2024
ad62112
Add property-read/write in phpdoc parsing
bart-jaskulski Nov 12, 2024
6d704cb
Restore native parser in tests
bart-jaskulski Nov 12, 2024
951bf7b
Move phpstan docblock usage flag to constructor
bart-jaskulski Nov 12, 2024
a7bd0e3
Add basic tests failing with phpstan parser
bart-jaskulski Nov 13, 2024
2d100c4
Fix false-positive unused import on array types
bart-jaskulski Nov 13, 2024
9f7d8d9
Rely on docblock type for return tag
bart-jaskulski Nov 13, 2024
54465e2
Add return type to keep phpstan happy
bart-jaskulski Nov 13, 2024
ba10ea5
Update phpstan/docblock-parser to v2
bart-jaskulski Nov 13, 2024
85f0d52
Update composer.lock file
bart-jaskulski Nov 13, 2024
deb6995
Control used phpdoc parser with config parameter
bart-jaskulski Nov 13, 2024
4f1ac6b
Change method visibility
bart-jaskulski Nov 13, 2024
109dd82
style: move public method higher in class hierarchy
bart-jaskulski Nov 14, 2024
087ede8
Add test for synthetic types usage
bart-jaskulski Nov 19, 2024
0096488
Merge remote-tracking branch 'upstream/master' into gh-2706
bart-jaskulski Nov 19, 2024
e5bae22
Add test for false-positive unused import
bart-jaskulski Nov 19, 2024
0f22d0f
Add missing test sources
bart-jaskulski Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change expected test result for phpstan doc parser 
Signed-off-by: Bart Jaskulski <bjaskulski@protonmail.com>
  • Loading branch information
@bart-jaskulski
bart-jaskulski committed Nov 13, 2024
commit 126fe578834ca8b4735a93c3f8de8cf73ac10c84
2 changes: 1 addition & 1 deletion lib/WorseReflection/Bridge/TolerantParser/Diagnostics/DocblockMissingExtendsTagProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class Foobar extends NeedGeneric
assertion: function (Diagnostics $diagnostics): void {
Assert::assertCount(1, $diagnostics);
Assert::assertEquals(
'Generic tag `@extends NeedGeneric` should be compatible with `@extends NeedGeneric<int>`',
'Missing generic tag `@extends NeedGeneric<int>`',
Comment thread
dantleech marked this conversation as resolved.
$diagnostics->at(0)->message()
);
}
Expand Down