Skip to content

Only enable symfony error handler in debug mode - #513

Open
jkrzefski wants to merge 1 commit into
php-pm:masterfrom
jkrzefski:patch-2
Open

jkrzefski wants to merge 1 commit into
php-pm:masterfrom
jkrzefski:patch-2

Conversation

@jkrzefski

Copy link
Copy Markdown
Contributor

I don't know why the Symfony error handler is always enabled. Maybe there is a deeper meaning behind it that I don't see. But if not, I propose to only use Debug when debugging is requested (via config or command option).

@acasademont

Copy link
Copy Markdown
Contributor

Not so sure about this one, if the server crashes (during the bridge bootstrap, for example) there might be very little info about what happened. Did you run some tests on it?

@jkrzefski

Copy link
Copy Markdown
Contributor Author

No, I did not run any tests on my end. I only looked through the code, spotted this and thought it looked wrong. The travis build seems fine, though.

I am totally ok with leaving it the way it was. I would merely like a short explanation on why the error handler is enabled in production. Maybe a comment in the code would be nice, so others don't get confused like I was.

@andig

andig commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

Enable during startup and disable after first client answer sent?

@andig

andig commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

I am totally ok with leaving it the way it was. I would merely like a short explanation on why the error handler is enabled in production. Maybe a comment in the code would be nice, so others don't get confused like I was.

Could you propose what you'd expect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants