Skip to content

PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haphan merged 16 commits into from
Feb 5, 2018
Merged

PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) #184

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9b53613
Added php7.2
haphan Dec 7, 2017
8250877
Renamed model Object to StorageObject
mrwogu Dec 16, 2017
3b5e574
Updated php-cs-fixer to 2.9.0 Speechless
mrwogu Dec 16, 2017
3b618fc
Fixed PSR2 php-cs-fixer rules
mrwogu Dec 16, 2017
dc927f4
Updated PHPUnit to 6.5 (stable)
mrwogu Dec 16, 2017
a5916e8
Updated tests to use new version PHPUnit
mrwogu Dec 16, 2017
c747738
Fixed PHPUnit tests
mrwogu Dec 19, 2017
546ff44
Removed return type for two methods in AbstractResource
mrwogu Dec 19, 2017
d21c534
Updated docks & readme
mrwogu Jan 6, 2018
fbddef5
Fixed code to PSR2 compatibility
mrwogu Jan 27, 2018
f837c8e
Fixed: Count returns 1 on StdClass object
mrwogu Jan 28, 2018
5e03d16
Update README.md
haphan Feb 3, 2018
78441f1
Added php_cs config
haphan Feb 5, 2018
a29d634
Updated BC breaks notice and version guidance
haphan Feb 5, 2018
b6ed2cd
Added strict mode, increase assertion count instead of assert true
haphan Feb 5, 2018
756a8f8
Updated php-cs-fixer
haphan Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed code to PSR2 compatibility
  • Loading branch information
@mrwogu
mrwogu committed Feb 3, 2018
commit fbddef50aed3753f21ac40db16b9ae0e5d7fa33a
42 changes: 28 additions & 14 deletions tests/unit/Networking/v2/Extensions/Layer3/Models/FloatingIpTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,20 +49,34 @@ public function test_it_retrieves()

$this->floatingIp->retrieve();

$this->assertEquals('376da547-b977-4cfe-9cba-275c80debf57',
$this->floatingIp->floatingNetworkId);
$this->assertEquals('d23abc8d-2991-4a55-ba98-2aaea84cc72f',
$this->floatingIp->routerId);
$this->assertEquals('10.0.0.3',
$this->floatingIp->fixedIpAddress);
$this->assertEquals('172.24.4.228',
$this->floatingIp->floatingIpAddress);
$this->assertEquals('4969c491a3c74ee4af974e6d800c62de',
$this->floatingIp->tenantId);
$this->assertEquals(
'376da547-b977-4cfe-9cba-275c80debf57',
$this->floatingIp->floatingNetworkId
);
$this->assertEquals(
'd23abc8d-2991-4a55-ba98-2aaea84cc72f',
$this->floatingIp->routerId
);
$this->assertEquals(
'10.0.0.3',
$this->floatingIp->fixedIpAddress
);
$this->assertEquals(
'172.24.4.228',
$this->floatingIp->floatingIpAddress
);
$this->assertEquals(
'4969c491a3c74ee4af974e6d800c62de',
$this->floatingIp->tenantId
);
$this->assertEquals('ACTIVE', $this->floatingIp->status);
$this->assertEquals('ce705c24-c1ef-408a-bda3-7bbd946164ab',
$this->floatingIp->portId);
$this->assertEquals('2f245a7b-796b-4f26-9cf9-9e82d248fda7',
$this->floatingIp->id);
$this->assertEquals(
'ce705c24-c1ef-408a-bda3-7bbd946164ab',
$this->floatingIp->portId
);
$this->assertEquals(
'2f245a7b-796b-4f26-9cf9-9e82d248fda7',
$this->floatingIp->id
);
}
}