Skip to content

New message transformation concept #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TiMESPLiNTER wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New message transformation concept #956

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e7e1cd
Pass whole message for deserialization
TiMESPLiNTER Sep 26, 2019
a6c1990
New message transformation concept
TiMESPLiNTER Sep 26, 2019
3a1b758
Remove unused use
TiMESPLiNTER Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Pass whole message for deserialization
  • Loading branch information
@TiMESPLiNTER
TiMESPLiNTER committed Sep 26, 2019
commit 7e7e1cd5a7bf595ec97c9d3b6691f6eb09ce7e1c
6 changes: 4 additions & 2 deletions pkg/rdkafka/JsonSerializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

namespace Enqueue\RdKafka;

use RdKafka\Message as VendorMessage;

class JsonSerializer implements Serializer
{
public function toString(RdKafkaMessage $message): string
Expand All @@ -25,9 +27,9 @@ public function toString(RdKafkaMessage $message): string
return $json;
}

public function toMessage(string $string): RdKafkaMessage
public function toMessage(VendorMessage $message): RdKafkaMessage
{
$data = json_decode($string, true);
$data = json_decode($message->payload, true);
if (JSON_ERROR_NONE !== json_last_error()) {
throw new \InvalidArgumentException(sprintf(
'The malformed json given. Error %s and message %s',
Expand Down
2 changes: 1 addition & 1 deletion pkg/rdkafka/RdKafkaConsumer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ private function doReceive(int $timeout): ?RdKafkaMessage
case RD_KAFKA_RESP_ERR__TIMED_OUT:
break;
case RD_KAFKA_RESP_ERR_NO_ERROR:
$message = $this->serializer->toMessage($kafkaMessage->payload);
$message = $this->serializer->toMessage($kafkaMessage);
$message->setKey($kafkaMessage->key);
$message->setPartition($kafkaMessage->partition);
$message->setKafkaMessage($kafkaMessage);
Expand Down
4 changes: 3 additions & 1 deletion pkg/rdkafka/Serializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@

namespace Enqueue\RdKafka;

use RdKafka\Message as VendorMessage;

interface Serializer
{
public function toString(RdKafkaMessage $message): string;

public function toMessage(string $string): RdKafkaMessage;
public function toMessage(VendorMessage $string): RdKafkaMessage;
}