Skip to content

Make zpp failures always throw, independent of strict_types #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikic wants to merge 53 commits into from
Closed

Make zpp failures always throw, independent of strict_types #3794

Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
b708b08
Make zpp failures always throw, independent of strict_types
nikic Feb 5, 2019
094b224
Rename some _exception APIs to _error
nikic Feb 19, 2019
1156bc5
Remove explicit uses of ZEND_PARSE_PARAMS_THROW
nikic Feb 19, 2019
3c10cf1
Start on test fixes
nikic Feb 19, 2019
14a702c
More test fixes
nikic Mar 5, 2019
32e5c7a
Intl: Don't separately report "bad arguments" errors
nikic Mar 5, 2019
90b29e4
More test updates
nikic Mar 5, 2019
48df358
Test tweaks
nikic Mar 5, 2019
f92fa89
gd tweaks
nikic Mar 5, 2019
e99ea84
Test tweaks
nikic Mar 5, 2019
3448a4c
Gmp fixes
nikic Mar 5, 2019
56d6635
Hash fixes
nikic Mar 5, 2019
2f2ee46
pcre fixes
nikic Mar 5, 2019
73de76c
Reflection fixes
nikic Mar 5, 2019
f67dc49
sockets test fixes
nikic Mar 6, 2019
3e0b31a
Remove some unnecessary error handler setting
nikic Mar 6, 2019
1f801dc
SPL test fixes
nikic Mar 6, 2019
29483fe
Standard array test updates
nikic Mar 6, 2019
4f7c13c
More spl fixes
nikic Mar 6, 2019
5d6e116
bz2 test fixes
nikic Mar 7, 2019
1f29b78
finfo test updates
nikic Mar 7, 2019
bdaa18a
filter test updates
nikic Mar 7, 2019
f40459c
json test updates
nikic Mar 7, 2019
01edef7
ftp test fixes
nikic Mar 7, 2019
a9f1a60
libxml test fixes
nikic Mar 7, 2019
226c2ff
openssl test fixes
nikic Mar 7, 2019
2d92914
phar test fixes
nikic Mar 7, 2019
73157d8
readline test fixes
nikic Mar 7, 2019
2fbf0a7
session test fixes
nikic Mar 7, 2019
a844db6
array test fixes
nikic Mar 7, 2019
c9f894d
class_object test fixes
nikic Mar 7, 2019
69eec09
general functions test fixes
nikic Mar 7, 2019
8e5a097
More string test fixes
nikic Mar 7, 2019
c3b19ec
More general functions test fixes
nikic Mar 7, 2019
9e590e7
Partial
nikic Mar 7, 2019
4ce6877
Math test fixes
nikic Mar 7, 2019
c1845f5
Stream test fixes
nikic Mar 7, 2019
98dce51
Misc test fixes
nikic Mar 7, 2019
5fd6079
Misc test updates
nikic Mar 8, 2019
1fd8ec5
mysqli test updates
nikic Mar 8, 2019
784762c
file test fixes
nikic Mar 8, 2019
7ae628a
Misc test updates
nikic Mar 8, 2019
d001b6a
Fix pgsql tests
nikic Mar 8, 2019
e182baa
Misc test fixes
nikic Mar 8, 2019
21853d0
Misc test updates
nikic Mar 8, 2019
30635d1
Misc fixes
nikic Mar 8, 2019
7d10143
Don't use custom soap error handling during zpp
nikic Mar 8, 2019
cfaecfb
Fix soap tests
nikic Mar 8, 2019
b7612d7
Remove zend_internal_type_error use in win32 specific code
nikic Mar 8, 2019
8f40d39
Use placeholder
nikic Mar 8, 2019
adc65e5
Try to fix windows tests
nikic Mar 8, 2019
d2ddf35
Fix more win32 tests
nikic Mar 11, 2019
5e4d9ba
Fix m32 tests
nikic Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't use custom soap error handling during zpp
  • Loading branch information
@nikic
nikic committed Mar 8, 2019
commit 7d101439b51161a9443e11c8b5a8d516a882a7b0
12 changes: 6 additions & 6 deletions ext/soap/soap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,12 +1111,12 @@ PHP_METHOD(SoapServer, __construct)
zend_long cache_wsdl;
HashTable *typemap_ht = NULL;

SOAP_SERVER_BEGIN_CODE();

if (zend_parse_parameters(ZEND_NUM_ARGS(), "z|a", &wsdl, &options) == FAILURE) {
php_error_docref(NULL, E_ERROR, "Invalid parameters");
return;
}

SOAP_SERVER_BEGIN_CODE();

if (Z_TYPE_P(wsdl) != IS_STRING && Z_TYPE_P(wsdl) != IS_NULL) {
php_error_docref(NULL, E_ERROR, "Invalid parameters");
}
Expand Down Expand Up @@ -2267,12 +2267,12 @@ PHP_METHOD(SoapClient, __construct)
HashTable *typemap_ht = NULL;
zval *this_ptr = ZEND_THIS;

SOAP_CLIENT_BEGIN_CODE();

if (zend_parse_parameters(ZEND_NUM_ARGS(), "z|a", &wsdl, &options) == FAILURE) {
php_error_docref(NULL, E_ERROR, "Invalid parameters");
return;
}

SOAP_CLIENT_BEGIN_CODE();

if (Z_TYPE_P(wsdl) != IS_STRING && Z_TYPE_P(wsdl) != IS_NULL) {
php_error_docref(NULL, E_ERROR, "$wsdl must be string or null");
}
Expand Down