Conversation
CertificateGenerator::generateKey() called openssl_pkey_new() without the test config, so it depended on the system openssl.cnf. When that file is missing, openssl_pkey_new() silently returns false and openssl_csr_new() generates the key itself using default_bits from the supplied config, which was 1024. OpenSSL 3.2+ defaults to security level 2 which rejects such keys, so TLS tests like gh10495 fail. Pass the test config explicitly so the explicit private_key_bits always applies, and bump the inline default_bits to 2048 for consistency. Closes phpGH-20176. Co-authored-by: velemas <velemas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CertificateGenerator::generateKey() called openssl_pkey_new() without the test config, so it depended on the system openssl.cnf. When that file is missing, openssl_pkey_new() silently returns false and openssl_csr_new() generates the key itself using default_bits from the supplied config, which was 1024. OpenSSL 3.2+ defaults to security level 2 which rejects such keys, so TLS tests like gh10495 fail.
Pass the test config explicitly so the explicit private_key_bits always applies, and bump the inline default_bits to 2048 for consistency.
Closes GH-20176.