Conversation
The new call is compiled to FETCH_DIM_FUNC_ARG going to FETCH_OBJ_FUNC_ARG. It tries to convert the FETCH_*_FUNC_ARG to FETCH_*_R, but it skips FETCH_DIM_FUNC_ARG with the UNUSED op2, and erroneously converts the next FETCH_OBJ_FUNC_ARG to FETCH_OBJ_R, which is an unexpected state for the optimizer. Interestingly, the reference path already had the appropriate check, so we move the check upwards and do the same thing as the reference path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new call is compiled to FETCH_DIM_FUNC_ARG going to FETCH_OBJ_FUNC_ARG. It tries to convert the
FETCH_*_FUNC_ARGtoFETCH_*_R, but it skips FETCH_DIM_FUNC_ARG with the UNUSED op2, and erroneously converts the next FETCH_OBJ_FUNC_ARG to FETCH_OBJ_R, which is an unexpected state for the optimizer.Interestingly, the reference path already had the appropriate check, so we move the check upwards and do the same thing as the reference path.