Clean up SAPI POST readers - #24057
Open
NattyNarwhal wants to merge 5 commits into
Open
NattyNarwhal wants to merge 5 commits into
NattyNarwhal wants to merge 5 commits into
Conversation
NattyNarwhal
commented
Oct 1, 2026
NattyNarwhal
commented
Member
- Remove the "default POST reader" as there was only ever one and the indirection is pointless.
- Move the default list of POST readers into the generic SAPI code and make it exported, so mbstring doesn't need a copy of it.
- Put the treat data and input filter initialization into its single caller.
- Fold php_content_types into the generic SAPI code.
There is only one of these; there's no point in the indirection here as it is never overrode, and set very early in main.c. Move the default post handling into the SAPI handling, and remove the pointless check if a default POST reader exists. This stuff was originally introduced in 98d95dd.
mbstring had a duplicate of this; remove some indirection and provide this as a symbol so it can be switched back to w/o duplication.
All its contents have been folded elsewhere. XXX: Perhaps php_std_post_handler belongs in php_variables.h?
NattyNarwhal
requested review from
alexdowad,
bukka and
youkidearitai
as code owners
October 1, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.