Repository navigation
Vision: Keep colons in OpenAI-compatible model IDs #5863 - #5872
Merged
Merged
Conversation
somaz94
added a commit
to somaz94/somaz94
that referenced
this pull request
Oct 1, 2026
Member
|
Thank you, @somaz94! Your fix is merged and part of the latest development build. Model IDs with colons, such as quant tags, While testing it, we made a few related refinements on top:
An explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
Engine: openai,GetModelsplit the configured identifier on the first colon and sent only the part before it. IDs likeunsloth/Qwen3.5-9B-GGUF:Q4_K_Mor OpenAI fine-tunes (ft:gpt-4o-mini-...) reached the server truncated, so every request failed with model not found.OpenAI-compatible servers match the ID verbatim, so
GetModelnow returns it unchanged for that engine. Ollama and the other engines still splitname:versionas before. I added two cases toTestModel_GetModeland updated the vision README.I tested this in the
photoprism/develop:260921-resoluteimage aftermake dep-models.go test ./internal/ai/vision/...andgo test ./internal/commands -run Visionpass,gofmtandgoimportsare clean, andgolangci-lintreports nothing on the changed lines. With the vision.yml from the issue,photoprism vision lsnow lists the model asunsloth/Qwen3.5-9B-GGUF:Q4_K_M.One thing I left alone:
openai.IsCloudModeldoes not look past theft:prefix, so a fine-tuned GPT model still gets the self-hosted defaults. Happy to follow up if you want that handled too.Related Issues
Fixes #5863
Acceptance Criteria