Skip to content

Fix: detect side-tab stripes drawn as child elements (#394) #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdulwahabone merged 12 commits into from
Oct 5, 2026
Merged

Fix: detect side-tab stripes drawn as child elements (#394) #804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5c67bf7
Fix: detect side-tab stripes drawn as child elements (#394)
abdulwahabone Sep 10, 2026
fc5dcef
Fix: tighten stripe-child text and static cascade gates (#394)
abdulwahabone Sep 10, 2026
3950a82
Fix: keep multiline JSX stripe-child matches (#394)
abdulwahabone Sep 10, 2026
afc0596
Merge main and preserve stripe-child coverage
pbakaus Sep 15, 2026
8b0cc87
Fix stripe-child edge and token matching
pbakaus Sep 15, 2026
7454f54
Merge main into stripe-child detection
pbakaus Sep 21, 2026
e940f01
Fix stripe height inference for definite-height boxes
pbakaus Sep 21, 2026
abc7785
Honor auto-height reset keywords in stripe detection
pbakaus Sep 21, 2026
f259950
Merge main into stripe-child detection
abdulwahabone Oct 5, 2026
46a3af7
Address Bugbot: relative widths, flex shorthands, inset-0 cue
abdulwahabone Oct 5, 2026
bce3c37
Address Greptile: absolute width units, var() flex shorthands
abdulwahabone Oct 5, 2026
b9e0ef0
Address Bugbot: fold case in flex keywords and the var() gate
abdulwahabone Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix stripe height inference for definite-height boxes 
Do not infer a full-height absolute stripe from opposing insets when height is definite. Cover px, rem, percent and calc corner tiles, and pin existing anchor/button exemptions. Full Rust workspace, rebuilt-engine Bun/Node suite and build pass; static and real Chrome agree on the repro.

AI-assisted by Codex under pbakaus's instructions.
  • Loading branch information
@pbakaus
pbakaus committed Sep 21, 2026
commit e940f019d8784a262d13a196ca76b90a285ab807
7 changes: 5 additions & 2 deletions crates/html/src/adapters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,8 +502,11 @@ pub fn check_element_stripe_child(el: &StaticElement<'_>, style: &StyleValues) -
// The cascade already expands inset; a winning `auto` longhand
// must not be overwritten by the earlier shorthand.
let inset = ["top", "right", "bottom", "left"].map(|prop| sv(style, prop));
let height_stretches =
height_raw == "100%" || (static_edge_hugs(&inset[0]) && static_edge_hugs(&inset[2]));
// Opposing insets stretch only an auto-height box. With a definite
// height CSS drops the bottom constraint instead of stretching it.
let height_stretches = height_raw == "100%"
|| ((height_raw.is_empty() || height_raw == "auto")
&& static_edge_hugs(&inset[0]) && static_edge_hugs(&inset[2]));
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
if !height_stretches {
return Vec::new();
}
Comment thread
cursor[bot] marked this conversation as resolved.
Expand Down
20 changes: 20 additions & 0 deletions crates/html/tests/stripe_child.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,26 @@ fn absolute_top_bottom_flags() {
assert!(hits[0].contains("stripe child (left)"));
}

#[test]
fn absolute_definite_height_does_not_stretch_between_insets() {
for height in ["4px", "1rem", "25%", "calc(2px + 2px)"] {
let html = format!(r#"<html><body><div style="position:relative;width:320px;height:100px">
<span style="position:absolute;left:0;top:0;bottom:0;width:4px;height:{height};background:#3b82f6"></span>
</div></body></html>"#);
assert!(side_tab_snippets(&html).is_empty(), "definite height {height} is not stretched");
}
}

#[test]
fn interactive_host_stripes_keep_the_border_rule_exemptions() {
for tag in ["a", "button"] {
let html = format!(r#"<html><body><{tag} style="position:relative;display:block;width:320px;height:100px">
<span style="position:absolute;left:0;top:0;bottom:0;width:4px;background:#3b82f6"></span>
</{tag}></body></html>"#);
assert!(side_tab_snippets(&html).is_empty(), "{tag} is an exempt control");
}
}

#[test]
fn flex_column_does_not_flag() {
let html = r#"<!DOCTYPE html><html><head><style>
Expand Down
Loading