Skip to content

Fix for quick direction change #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patorjk merged 3 commits into from
Oct 12, 2019
Merged

Fix for quick direction change #56

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81629e1
fix move queue
dginovker Oct 2, 2019
cfb31c2
Added premove
dginovker Oct 2, 2019
14b1d9b
Fix starting move
dginovker Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added premove
  • Loading branch information
@dginovker
dginovker committed Oct 2, 2019
commit cfb31c2ca701643b03ff54fe675f53e905cc8fd6
39 changes: 26 additions & 13 deletions js/snake.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ SNAKE.Snake = SNAKE.Snake || (function() {
playingBoard = config.playingBoard,
myId = instanceNumber++,
growthIncr = 5,
lastMove = 1;
lastMove = 1,
preMove = -1,
isFirstMove = true,
currentDirection = -1, // 0: up, 1: left, 2: down, 3: right
columnShift = [0, 1, 0, -1],
rowShift = [-1, 0, 1, 0],
Expand Down Expand Up @@ -233,32 +235,35 @@ SNAKE.Snake = SNAKE.Snake || (function() {
//console.log("lastmove="+lastMove);
//console.log("dir="+keyNum);

let directionFound = -1;

switch (keyNum) {
case 37:
case 65:
if ( lastMove !== 1 || snakeLength === 1 ) {
currentDirection = 3;
}
directionFound = 3;
break;
case 38:
case 87:
if ( lastMove !== 2 || snakeLength === 1 ) {
currentDirection = 0;
}
directionFound = 0;
break;
case 39:
case 68:
if ( lastMove !== 3 || snakeLength === 1 ) {
currentDirection = 1;
}
directionFound = 1;
break;
case 40:
case 83:
if ( lastMove !== 0 || snakeLength === 1 ) {
currentDirection = 2;
}
directionFound = 2;
break;
}
if (currentDirection !== lastMove) // Allow a queue of 1 premove so you can turn again before the first turn registers
{
preMove = directionFound;
}
if (Math.abs(directionFound - lastMove) !== 2 && isFirstMove) // Prevent snake from turning 180 degrees
{
currentDirection = directionFound;
isFirstMove = false;
}
};

/**
Expand Down Expand Up @@ -286,7 +291,13 @@ SNAKE.Snake = SNAKE.Snake || (function() {

if (currentDirection !== -1){
lastMove = currentDirection;
if (preMove !== -1) // If the user queued up another move after the current one
{
currentDirection = preMove; // Execute that move next time (unless overwritten)
preMove = -1;
}
}
isFirstMove = true;

newHead.col = oldHead.col + columnShift[lastMove];
newHead.row = oldHead.row + rowShift[lastMove];
Expand Down Expand Up @@ -371,6 +382,8 @@ SNAKE.Snake = SNAKE.Snake || (function() {
*/
me.rebirth = function() {
isDead = false;
isFirstMove = true;
preMove = -1;
};

/**
Expand Down