Repository navigation
feat(wall): typed exact length during two-click wall drafting #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkbbdev
wants to merge
8
commits into
pascalorg:main
Choose a base branch
from
dkbbdev:feat/wall-typed-length
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9a3002e
feat(wall): typed exact length during two-click wall drafting (#308)
dkbbdev 11e8fa5
fix(wall): address review — commit typed length exactly, no buffer leaks
dkbbdev 596c7e7
fix(wall): honor typed length on Enter/click exits, latest-ref for 2D…
dkbbdev b6da3b6
merge: upstream main (hosting fixes #894-#896, settings dialog #904, …
dkbbdev afe71e4
fix(wall): re-derive typed endpoint at click commit time
dkbbdev 43d7a64
fix(wall): let the 2D-only view own the typed Enter commit
dkbbdev 7e114a8
fix(wall): round-4 bugbot fixes for the typed 2D draft
dkbbdev 69100e1
merge: upstream main (authored objects, freeform elements, scripted o…
dkbbdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(wall): let the 2D-only view own the typed Enter commit
Bugbot cb434c3d (round 4, high): the 3D tool's capture-phase Enter handler synthesized grid:click and stopped the event, so the 2D Enter path never ran handleWallPlacementPoint. In 2D-only that click pipeline commits nothing (the canvas is display:none), so a typed Enter silently did nothing; in split view the 3D commit left the panel's draftStart on the previous segment, so the next 2D preview and typed commit projected from a stale origin. The tool's key handler now yields in 2D-only view — the floor-plan panel is the committer there (view-gated createWallOnCurrentLevel already exists). For split view, the panel subscribes to the chain start the 3D tool publishes on useSegmentDraftChain and re-bases its draft onto it, so both views keep drafting from the same point with a single commit owner. The subscription re-arms reactively on mode/tool instead of reading the store once at mount. check-types + biome + editor (1072) + nodes (3393) suites pass.
- Loading branch information
commit 43d7a64e15230e45f06347d731352bfce2d68672
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.