Skip to content

Add PolygonSeries #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
VisualMelon wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Add PolygonSeries #2033

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b7fdb6
Add basic polygon series implementation
VisualMelon Mar 13, 2021
2a5c03c
Fix build
VisualMelon Aug 16, 2023
f31c040
Update changelog
VisualMelon Aug 16, 2023
0a78090
Fixed a failed test to succeed.
SadashimaSeiya Sep 27, 2024
e1135f7
Merge pull request #1 from SADASHIMA/polygonseries
VisualMelon Sep 27, 2024
9284b91
Added me as a contributor
SadashimaSeiya Oct 1, 2024
4174649
Merge pull request #2 from SADASHIMA/polygonseries
VisualMelon Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/OxyPlot/Series/PolygonItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public string ToCode()
{
// TODO: teach FormatConstructor to translate arrays
var outlineCode = string.Format("new DataPoint[][] {0}", string.Join(",", this.Outlines.Select(outline => string.Format("new DataPoint[] {0}", outline.Select(p => p.ToCode())))));
return CodeGenerator.FormatConstructor(this.GetType(), "{0},{2}", outlineCode, this.Value);
return CodeGenerator.FormatConstructor(this.GetType(), "{0},{1}", outlineCode, this.Value);
}

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Source/OxyPlot/Series/PolygonSeries.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ protected void RenderPolygons(IRenderContext rc, ICollection<PolygonItem> items)
foreach (var outline in item.Outlines)
{
screenPointOutline.Clear();
screenPointOutline.AddRange(outline.Select(Transform));
screenPointOutline.AddRange(outline.Select(this.Transform));

rc.DrawPolygon(
screenPointOutline,
Expand Down Expand Up @@ -281,7 +281,7 @@ public override TrackerHitResult GetNearestPoint(ScreenPoint point, bool interpo

// check against polygon
screenPointOutline.Clear();
screenPointOutline.AddRange(item.Outlines[i].Select(Transform));
screenPointOutline.AddRange(item.Outlines[i].Select(this.Transform));

if (ScreenPointHelper.IsPointInPolygon(point, screenPointOutline))
{
Expand Down