Skip to content

[FSSDK-13110] cache update #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junaed-optimizely merged 3 commits into from
Sep 14, 2026
Merged

[FSSDK-13110] cache update #1175

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a626884
[FSSDK-13110] cache update
junaed-optimizely Sep 7, 2026
1ae6fef
[FSSDK-13110] name update
junaed-optimizely Sep 14, 2026
3ba3b7d
[FSSDK-13110] name update to tests
junaed-optimizely Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[FSSDK-13110] name update to tests
  • Loading branch information
@junaed-optimizely
junaed-optimizely committed Sep 14, 2026
commit 3ba3b7d73a3f60dec81c237ce2c15b6b8593a8b9
14 changes: 7 additions & 7 deletions lib/project_config/polling_datafile_manager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ describe('PollingDatafileManager', () => {
const repeater = getMockRepeater();
const requestHandler = getMockRequestHandler(); // response promise is pending
const cache = getMockAsyncCache<string>();
await cache.set('opt-datafile-v6-keyThatExists', JSON.stringify({ name: 'keyThatExists' }));
await cache.set('optimizely-datafile-keyThatExists', JSON.stringify({ name: 'keyThatExists' }));

const manager = new PollingDatafileManager({
repeater,
Expand All @@ -131,7 +131,7 @@ describe('PollingDatafileManager', () => {
requestHandler.makeRequest.mockReturnValueOnce(mockResponse);

const cache = getMockAsyncCache<string>();
await cache.set('opt-datafile-v6-keyThatExists', JSON.stringify({ name: 'keyThatExists' }));
await cache.set('optimizely-datafile-keyThatExists', JSON.stringify({ name: 'keyThatExists' }));

const manager = new PollingDatafileManager({
repeater,
Expand All @@ -155,7 +155,7 @@ describe('PollingDatafileManager', () => {
const repeater = getMockRepeater();
const requestHandler = getMockRequestHandler();
const cache = getMockAsyncCache<string>();
await cache.set('opt-datafile-v6-keyThatExists', JSON.stringify({ name: 'keyThatExists' }));
await cache.set('optimizely-datafile-keyThatExists', JSON.stringify({ name: 'keyThatExists' }));
const mockResponse = getMockAbortableRequest();
requestHandler.makeRequest.mockReturnValueOnce(mockResponse);

Expand Down Expand Up @@ -564,7 +564,7 @@ describe('PollingDatafileManager', () => {
repeater.execute(0);

await expect(manager.onRunning()).resolves.not.toThrow();
expect(spy).toHaveBeenCalledWith('opt-datafile-v6-keyThatDoesNotExists', '{"foo": "bar"}');
expect(spy).toHaveBeenCalledWith('optimizely-datafile-keyThatDoesNotExists', '{"foo": "bar"}');
});
});

Expand Down Expand Up @@ -635,9 +635,9 @@ describe('PollingDatafileManager', () => {
}

await expect(manager.onRunning()).resolves.not.toThrow();
expect(spy).toHaveBeenNthCalledWith(1, 'opt-datafile-v6-keyThatDoesNotExists', '{"foo": "bar"}');
expect(spy).toHaveBeenNthCalledWith(2, 'opt-datafile-v6-keyThatDoesNotExists', '{"foo2": "bar2"}');
expect(spy).toHaveBeenNthCalledWith(3, 'opt-datafile-v6-keyThatDoesNotExists', '{"foo3": "bar3"}');
expect(spy).toHaveBeenNthCalledWith(1, 'optimizely-datafile-keyThatDoesNotExists', '{"foo": "bar"}');
expect(spy).toHaveBeenNthCalledWith(2, 'optimizely-datafile-keyThatDoesNotExists', '{"foo2": "bar2"}');
expect(spy).toHaveBeenNthCalledWith(3, 'optimizely-datafile-keyThatDoesNotExists', '{"foo3": "bar3"}');
});

it('logs an error if fetch request fails and does not call onUpdate handler', async () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/project_config/polling_datafile_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class PollingDatafileManager extends BaseService implements DatafileManag
logger,
} = config;
this.cache = cache;
this.cacheKey = 'optimizely-datafile' + sdkKey;
this.cacheKey = 'optimizely-datafile-' + sdkKey;
this.sdkKey = sdkKey;
this.datafileAccessToken = datafileAccessToken;
this.customHeaders = customHeaders;
Expand Down
Loading