Repository navigation
Perform safety checks in create-stack-user.sh - #50
Closed
jimrollenhagen wants to merge 1 commit into
Closed
jimrollenhagen wants to merge 1 commit into
jimrollenhagen wants to merge 1 commit into
Conversation
This adds some safety checks to the stack user creation script. This includes: - Using set -e to exit early on errors - Make sure the `functions` script exists - Make sure the `stackrc` script exists - Make sure STACK_USER is set before doing anything with it
Contributor
Author
|
Closing in favor of https://review.openstack.org/#/c/74488/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some safety checks to the stack user creation script.
This includes:
functionsscript existsstackrcscript existsWhy is this necessary? I managed to run this with
sh, STACK_USER did not get set, and the end result was a broken sudoers file. Not fun.