Skip to content

Switch to PEP 621 project metadata; build sdist and all wheels in CI #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgilbert merged 8 commits into from
Nov 2, 2023
Merged

Switch to PEP 621 project metadata; build sdist and all wheels in CI #237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e9cc7d5
templates/release: procedure updates
bgilbert Nov 1, 2023
ef61785
workflows: fail on curl error
bgilbert Nov 1, 2023
b893ba2
Switch to PEP 621 project metadata
bgilbert Nov 1, 2023
37f6fb9
workflows: build with Python `build` package
bgilbert Nov 1, 2023
d6af87d
workflows: build wheels for Linux and macOS
bgilbert Nov 1, 2023
3e2c3b5
workflows: generate sdist tarball in CI
bgilbert Nov 1, 2023
fe10747
pre-commit-config: bump versions
bgilbert Nov 1, 2023
83b18c7
Move isort, pytest, rstcheck configs into pyproject.toml
bgilbert Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
workflows: generate sdist tarball in CI 
By omitting the `python -m build` -w argument in one job, verify that the
source tarball can successfully build a wheel.  Use that source tarball in
releases rather than building it on a developer's machine.

Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
  • Loading branch information
@bgilbert
bgilbert committed Nov 1, 2023
commit 3e2c3b506df0064a73f4246de3f96cb7f4e7d5ff
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
- [ ] `git clean -dxf && mkdir dist`
- [ ] Find the [workflow run](https://github.com/openslide/openslide-python/actions) for the tag; download its docs and wheels artifacts
- [ ] `unzip /path/to/downloaded/openslide-python-wheels.zip && mv openslide-python-wheels-*/* dist/`
- [ ] `python setup.py sdist`
- [ ] `twine upload dist/*`
- [ ] Recompress tarball with `xz`
- [ ] Attach release notes to [GitHub release](https://github.com/openslide/openslide-python/releases/new); upload tarballs and wheels
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ jobs:
os: [ubuntu-latest, macos-latest]
python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
include:
- os: ubuntu-latest
python-version: "3.12"
sdist: sdist
# Python 3.8 is too old to support universal binaries, and
# setup-python's Python 3.9 and 3.10 won't build them. Use the
# last upstream patch releases that ship with installers.
Expand Down Expand Up @@ -82,7 +85,10 @@ jobs:
esac
- name: Build wheel
run: |
python -m build -w
if [ -z "${{ matrix.sdist }}" ]; then
wheel_only=-w
fi
python -m build $wheel_only
case "${{ matrix.os }}" in
ubuntu-*)
mkdir old
Expand Down