OCPBUGS-15215: OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift by Patryk-Stefanski · Pull Request #3041 · openshift/hypershift

Patryk-Stefanski · 2023-09-25T08:33:53Z

What this PR does / why we need it:
Fixes OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift bug.

Which issue(s) this PR fixes :
Fixes #

https://issues.redhat.com/browse/OCPBUGS-15215

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2023-09-25T08:33:58Z

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-15215, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:
Fixes OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift bug.

Which issue(s) this PR fixes :
Fixes #

https://issues.redhat.com/browse/OCPBUGS-15215

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2023-09-25T09:01:49Z

/approve

openshift-ci · 2023-09-25T09:02:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre · 2023-09-25T09:03:15Z

+			util.BuildVolume(oauthVolumeErrorTemplate(), func(volume *corev1.Volume) {
+				buildOAuthVolumeErrorTemplate(volume, params)
+			}),
+			util.BuildVolume(oauthVolumeLoginTemplate(), func(volume *corev1.Volume) {


it'd be nice to have a unit test that validates reconcileDeployment set the right volumes for the right hcp input

Do you think this test is sufficient link ? We never change the name of the volume being used it's just the secret that changes depending on whether the templates are specified or not and think this should cover it.

netlify · 2023-09-25T12:22:20Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`1c98d69`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/65117b5681c00b00080ca647
😎 Deploy Preview	https://deploy-preview-3041--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sjenning · 2023-09-25T16:16:28Z

/lgtm

sjenning · 2023-09-26T13:20:37Z

/jira refresh

openshift-ci-robot · 2023-09-26T13:20:44Z

@sjenning: This pull request references Jira Issue OCPBUGS-15215, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-09-26T19:50:57Z

@Patryk-Stefanski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-09-26T19:53:37Z

@Patryk-Stefanski: Jira Issue OCPBUGS-15215: All pull requests linked via external trackers have merged:

openshift/hypershift#3041

Jira Issue OCPBUGS-15215 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:
Fixes OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift bug.

Which issue(s) this PR fixes :
Fixes #

https://issues.redhat.com/browse/OCPBUGS-15215

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-09-27T15:59:47Z

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

Patryk-Stefanski changed the title ~~OCPBUGS-15215: s OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift~~ OCPBUGS-15215: OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift Sep 25, 2023

openshift-ci Bot added the do-not-merge/needs-area label Sep 25, 2023

openshift-ci Bot requested review from csrwng and isco-rodriguez September 25, 2023 08:34

openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Sep 25, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023

enxebre reviewed Sep 25, 2023

View reviewed changes

OCPBUGS-15215 honoring oauth configration in hypershift

1c98d69

Patryk-Stefanski force-pushed the OCPBUGS-15215 branch from 00ad4a2 to 1c98d69 Compare September 25, 2023 12:21

Patryk-Stefanski changed the title ~~OCPBUGS-15215: OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift~~ Draft: OCPBUGS-15215: OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift Sep 25, 2023

Patryk-Stefanski changed the title ~~Draft: OCPBUGS-15215: OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift~~ OCPBUGS-15215: OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift Sep 25, 2023

openshift-ci Bot assigned sjenning Sep 25, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 26, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 26, 2023

openshift-merge-robot merged commit 696f8d5 into openshift:main Sep 26, 2023

Navigation Menu

Repository navigation

OCPBUGS-15215: OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift - #3041

OCPBUGS-15215: OAuth template config in HostedCluter.configuration.ouath is not honored in HyperShift#3041
openshift-merge-robot merged 1 commit into
openshift:mainfrom
Patryk-Stefanski:OCPBUGS-15215

Patryk-Stefanski commented Sep 25, 2023

Uh oh!

openshift-ci-robot commented Sep 25, 2023

Uh oh!

enxebre commented Sep 25, 2023

Uh oh!

openshift-ci Bot commented Sep 25, 2023

Uh oh!

enxebre Sep 25, 2023

Uh oh!

Patryk-Stefanski Sep 25, 2023

Uh oh!

netlify Bot commented Sep 25, 2023

Uh oh!

sjenning commented Sep 25, 2023

Uh oh!

sjenning commented Sep 26, 2023

Uh oh!

openshift-ci-robot commented Sep 26, 2023

Uh oh!

openshift-ci Bot commented Sep 26, 2023

Uh oh!

openshift-ci-robot commented Sep 26, 2023

Uh oh!

openshift-merge-robot commented Sep 27, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Patryk-Stefanski commented Sep 25, 2023

Uh oh!

openshift-ci-robot commented Sep 25, 2023

Uh oh!

enxebre commented Sep 25, 2023

Uh oh!

openshift-ci Bot commented Sep 25, 2023

Uh oh!

enxebre Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

Patryk-Stefanski Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

netlify Bot commented Sep 25, 2023

✅ Deploy Preview for hypershift-docs ready!

Uh oh!

sjenning commented Sep 25, 2023

Uh oh!

sjenning commented Sep 26, 2023

Uh oh!

openshift-ci-robot commented Sep 26, 2023

Uh oh!

openshift-ci Bot commented Sep 26, 2023

Uh oh!

openshift-ci-robot commented Sep 26, 2023

Uh oh!

openshift-merge-robot commented Sep 27, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants