Repository navigation
Fix collections.abc DeprecationWarning in sample.py - #936
Merged
Merged
Conversation
Member
|
I think you're gonna need a try: except: for Python 2. |
Member
Author
|
Yeah, figured that one out. Decided to explicitly check for python3 so it is easier to remove if/when OPS drops python |
Member
|
Sure... I usually add a comment with the string |
dwhswenson
approved these changes
Oct 17, 2020
dwhswenson
left a comment
dwhswenson
left a comment
Member
There was a problem hiding this comment.
Code looks good. Will merge on green.
dwhswenson
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going from 5570cd3 to ace9d7e and running the tests surfaced another
This solves that one (
Counterstill has to be imported from basecollections)