Repository navigation
use uuid instead of 'is' for selecting ensembles in rate calculation - #919
Merged
Merged
Conversation
dwhswenson
approved these changes
Jun 30, 2020
dwhswenson
left a comment
Member
There was a problem hiding this comment.
This works, but note that this code path is likely to be removed in the relatively near future. The better way to do TIS analysis is the stuff in analysis.tis, and at some point a default version of that will replace the network.rate_matrix() (and related) code, which is untested and less customizable.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up on experimental storage, but should also be a bug on
master.If you load your
networkfrom oneStorage object, but yourstepsfrom another (loading the same file), you might end up with 2 differentinstancesof the sameEnsemble.The
isevaluation is then too strict to handle this.I opted to convert this to an
uuid == uuidI am having trouble setting up a test case for this, so if you have any pointers for that @dwhswenson, please let me know.
I would envision something like this should fail on master (but I don't have any workable
.ncfiles at the moment, and couldn't quickly spot one in the test directory)