Repository navigation
Fix pandas Deprecaction and Future Warnings - #898
Merged
Merged
Conversation
dwhswenson
requested changes
Feb 6, 2020
dwhswenson
left a comment
dwhswenson
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix. Looks good, except a few code style changes I disagree with.
In general, I think that:
some_deeply_nested_long_function_name_with_complex_kwargs(
kwarg1=value,
kwarg2={dict_key: [list1, list2]}
)looks better than
some_deeply_nested_long_function_name_with_complex_kwargs(kwarg1=value,
kwarg2={dict_key: [list1,
list2]})If the args are likely to hit the 80 char limit (or are sufficiently complex), I put them in the first style above.
Undo a couple minor style changes, and this is good to go!
Member
Author
|
@dwhswenson all (un)done |
dwhswenson
approved these changes
Feb 7, 2020
Member
|
Waiting for tests to finish; then will merge! |
dwhswenson
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started with the warnings:
and
Which led to the same warnings as #881 after touching the files.
This also fixes some pep8 complaints and a small logic error in
TestTotalCrossingProbability.test_calculate()where the result was checked for AB twice instead of bothABandBA