Repository navigation
Progress indicators for TIS analysis - #895
Merged
dwhswenson merged 6 commits intoFeb 9, 2020
Merged
Conversation
dwhswenson
changed the title
Member
Author
|
This is ready for review/merge. I will leave it up for at least 24 hours, merging no earlier than Sunday night, 9 February. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#882 introduced adapters for progress indicators (namely, tqdm). This PR integrates that into the "new" TIS analysis. (The "new" analysis, which is about 2 years old, is described in this document and this example notebook. It isn't the default yet because it isn't compatible with files created by very old version of OPS -- I think pre 0.9.3 -- which we use for our tests.)
If you have tqdm installed, you'll automatically get progress bars. You can also customize the behavior, including easily silencing the progress bars.
The goal of this PR is to get these fully working for the
StandardTISAnalysis, along with conveniences for changing some behavior.