Skip to content

Deprecate MSMBuilder #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwhswenson merged 4 commits into from
Sep 19, 2019
Merged

Deprecate MSMBuilder #853

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cd2bb2
deprecate MSMBuilder
dwhswenson Sep 17, 2019
50e863f
remove MSMBuilder from requirements
dwhswenson Sep 17, 2019
c6186a6
fix missing =
dwhswenson Sep 17, 2019
58db705
misc fixes
dwhswenson Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
misc fixes 
how stupid can I be?
  • Loading branch information
@dwhswenson
dwhswenson committed Sep 17, 2019
commit 58db7055525ded323035c610dc271d1cdd25f718
3 changes: 2 additions & 1 deletion openpathsampling/collectivevariable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
from openpathsampling.netcdfplus import WeakKeyCache, \
ObjectJSON, create_to_dict, ObjectStore, PseudoAttribute

from deprecations import has_deprecations, deprecate, MSMBUILDER
from openpathsampling.deprecations import (has_deprecations, deprecate,
MSMBUILDER)

import sys
if sys.version_info > (3, ):
Expand Down
2 changes: 1 addition & 1 deletion openpathsampling/deprecations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def version_tuple_to_string(version_tuple):
)

MSMBUILDER = Deprecation(
problem=("MSMBuilder is no longer maintained. ",
problem=("MSMBuilder is no longer maintained. "
+ "MSMBFeaturizer is no longer officially supported."),
remedy="Create a CoordinateFunctionCV based on MSMBuilderFeaturizers.",
remove_version=(2, 0),
Expand Down