Skip to content

Update docs; remove need for conda (library) in dev install - #847

Merged
dwhswenson merged 5 commits into
masterfrom
docs_deploy
Jul 23, 2019
Merged

dwhswenson merged 5 commits into
masterfrom
docs_deploy

Conversation

@dwhswenson

@dwhswenson dwhswenson commented Jul 23, 2019 •

Copy link
Copy Markdown
Member

Fixes #846, plus a few other issues (in particular, I noticed that our docs were building on all Python versions, not only the deploy version — not a problem, but a waste of time on Travis.)

  • Fix docs license info
  • Fix mention of Python 3.5+
  • Fix discussion of Pytest/Nose
  • Fix install script to not require conda
  • Fix issue with docs building for all versions
  • Add acknowledgments to TOC so the link is in the sidebar

@dwhswenson

Copy link
Copy Markdown
Member Author

@sroet : Can you verify that this fixes for you? Since the change is in a secondary script in the repo, not the conda_ops_dev_install.sh script itself, you can run the normal procedure, except do:

bash conda_ops_dev_install.sh openpathsampling docs_deploy

That will check out the openpathsampling/docs_deploy branch, where these changes are, and run the install based on the information in that repo (using the updated script to get requirements, which shouldn't require that conda is installed.)

Also, could you review the changes here, since most of them are to address lack of clarity in the docs that you identified in #846?

@dwhswenson dwhswenson added misc PR docs issues/PRs related to documentation labels Jul 23, 2019

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the install works for 3.6 it doe (fails for 3.5 because of yaml versions, but the docs are updated to indicate 3.6 is the lowest py3 version to be tested, so that is fine by me).

@dwhswenson

Copy link
Copy Markdown
Member Author

fails for 3.5 because of yaml versions

Just curious: what do you mean by this?

(Also, currently having some weird flaky test fail in test_pyemma notebook; I'll try to track that down before merging. I can't imagine it has anything to do with this PR, but there also don't seem to be any version changes in requirements).

@sroet

sroet commented Jul 23, 2019

Copy link
Copy Markdown
Member

On python=3.5 this still fails to install matplotlib, due to

Traceback (most recent call last):
  File "devtools/install_recipe_requirements.py", line 42, in <module>
    required_packages = recipe_to_requirements(recipe_yaml)
  File "devtools/install_recipe_requirements.py", line 34, in recipe_to_requirements
    reqs = yaml.load(recipe_yaml, Loader=yaml.FullLoader)['requirements']
AttributeError: module 'yaml' has no attribute 'FullLoader'

which is probably due to the fact that pyyaml=3.13 for py3.5 and 5.1.1 for py3.6.

@dwhswenson

Copy link
Copy Markdown
Member Author

Ah, yeah, the script to find reqs will now require newer versions of pyyaml, and I guess they never released those for Python 3.5. The explicit Loader silences an annoying warning in pyyaml. Story behind that here.

@dwhswenson

Copy link
Copy Markdown
Member Author

We're definitely getting flakey errors in the test_pyemma notebook. Something to do with storage, it appears. But I can't find any version differences that make the problem evident.

Anyway, @sroet says that this fixes his problems, and it's mainly docs anyway, so I'm going to ahead and merge this.

@dwhswenson
dwhswenson merged commit a11d56f into master Jul 23, 2019
@dwhswenson
dwhswenson deleted the docs_deploy branch July 23, 2019 12:53
@dwhswenson
dwhswenson restored the docs_deploy branch July 23, 2019 12:53
This was referenced Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs issues/PRs related to documentation misc PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev install script is not installing matplotlib for py35

2 participants