Repository navigation
Fix notebook tests - #797
Merged
dwhswenson merged 4 commits intoSep 14, 2018
Merged
Conversation
Tests pass locally, but fail on Travis. What does Travis see?
Member
Author
|
Tests pass again. Giving 24 hours for review before self-merge (because this is a really small change, and we need it to pass tests again). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have notebook tests failing in
test_cv.ipynbandtest_netcdfplus.ipynb. This seems to be because of something with the numpy string representation (becauseipynbtestcompares string representation here).This PR will fix it (or find a way around it).